[NNC] Fixing a bug in simplifier #58291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
oncall: jit
💊 CI failures summary and remediationsAs of commit 22dfe5a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
bertmaher
approved these changes
May 14, 2021
This bug manifests when multiplying a polynomial by a term. It was because the scalar from the polynomial was not multiplied by the entire term, instead it was multiplied only by the scalar in the term. Differential Revision: [D28435393](https://our.internmc.facebook.com/intern/diff/D28435393) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ZolotukhinM
approved these changes
May 17, 2021
This bug manifests when multiplying a polynomial by a term. It was because the scalar from the polynomial was not multiplied by the entire term, instead it was multiplied only by the scalar in the term. Differential Revision: [D28435393](https://our.internmc.facebook.com/intern/diff/D28435393) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This bug manifests when multiplying a polynomial by a term. It was because the scalar from the polynomial was not multiplied by the entire term, instead it was multiplied only by the scalar in the term. Differential Revision: [D28435393](https://our.internmc.facebook.com/intern/diff/D28435393) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#58291 Test Plan: Imported from OSS Reviewed By: bertmaher Differential Revision: D28435393 Pulled By: navahgar fbshipit-source-id: 517e47385a93a43d2ddf054382adc81c18484066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This bug manifests when multiplying a polynomial by a term. It was because the scalar from the polynomial was not multiplied by the entire term, instead it was multiplied only by the scalar in the term.
Differential Revision: D28435393