fx quant: remove some dead code in observer insertion

[vkuzo]

Stack from ghstack:

• fx quant: remove some dead code in observer insertion #58574 fx quant: remove some dead code in observer insertion

Summary:

This code is not used anywhere, it was added by
#57519 but it was dead on
arrival. Inserting observers for output is handled in a different
function.

Test Plan:

python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D28544631

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit aee8f84 (more details on the Dr. CI page):

---

• 3/3 failures possibly* introduced in this PR
  • 1/3 non-scanned failure(s)

---

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 19 22:01:18 AssertionError: False is not tr...lowed difference with rtol=0 and atol=0 is only 0!

May 19 22:01:18 ----------------------------------------------------------------------
May 19 22:01:18 Traceback (most recent call last):
May 19 22:01:18   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 391, in wrapper
May 19 22:01:18     self._join_processes(fn)
May 19 22:01:18   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 583, in _join_processes
May 19 22:01:18     self._check_return_codes(elapsed_time)
May 19 22:01:18   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 645, in _check_return_codes
May 19 22:01:18     msg="Expected zero exit code but got {}".format(first_process.exitcode)
May 19 22:01:18   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1400, in assertEqual
May 19 22:01:18     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
May 19 22:01:18 AssertionError: False is not true : Scalars failed to compare as equal! Comparing -11 and 0 gives a difference of 11, but the allowed difference with rtol=0 and atol=0 is only 0!
May 19 22:01:18 Expected zero exit code but got -11
May 19 22:01:18 
May 19 22:01:18 ----------------------------------------------------------------------
May 19 22:01:18 Ran 46 tests in 18.776s
May 19 22:01:18 
May 19 22:01:18 FAILED (failures=31, skipped=15)
May 19 22:01:18 
May 19 22:01:18 Generating XML reports...
May 19 22:01:18 Generated XML report: test-reports/python-unittest/distributed.test_c10d_gloo/TEST-ProcessGroupGlooTest-20210519220100.xml
May 19 22:01:19 Traceback (most recent call last):

Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / test (2/2)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-05-19T20:02:43.0033411Z Build left local git repository checkout dirty

2021-05-19T20:02:36.9202195Z real	73m5.596s
2021-05-19T20:02:36.9202675Z user	127m10.695s
2021-05-19T20:02:36.9203086Z sys	26m43.892s
2021-05-19T20:02:36.9203544Z + assert_git_not_dirty
2021-05-19T20:02:36.9204818Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *rocm* ]]
2021-05-19T20:02:36.9205690Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *xla* ]]
2021-05-19T20:02:36.9206423Z ++ git status --porcelain
2021-05-19T20:02:43.0030865Z + git_status=' M third_party/tensorpipe'
2021-05-19T20:02:43.0031998Z + [[ -n  M third_party/tensorpipe ]]
2021-05-19T20:02:43.0032909Z + echo 'Build left local git repository checkout dirty'
2021-05-19T20:02:43.0033411Z Build left local git repository checkout dirty
2021-05-19T20:02:43.0034146Z + echo 'git status --porcelain:'
2021-05-19T20:02:43.0034597Z git status --porcelain:
2021-05-19T20:02:43.0035074Z + echo ' M third_party/tensorpipe'
2021-05-19T20:02:43.0035474Z  M third_party/tensorpipe
2021-05-19T20:02:43.0035783Z + exit 1
2021-05-19T20:02:43.0036056Z + cleanup
2021-05-19T20:02:43.0036324Z + retcode=1
2021-05-19T20:02:43.0036595Z + set +x
2021-05-19T20:02:43.0036925Z =================== sccache compilation log ===================
2021-05-19T20:02:43.0228668Z =========== If your build fails, please take a look at the log above for possible reasons ===========

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[vkuzo]

@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[vkuzo]

closing in favor of #59799