Skip to content

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented May 25, 2021

Stack from ghstack:

Was observing behavior where 7zip was nowhere to be found after a build
was completed. Let's just have 7zip be installed within the workflow as
well just to be completely sure 7zip is there.

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Differential Revision: D28681241

Was observing behavior where 7zip was nowhere to be found after a build
was completed. Let's just have 7zip be installed within the workflow as
well just to be completely sure 7zip is there.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2021

💊 CI failures summary and remediations

As of commit 7415c7e (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

seemethere added a commit that referenced this pull request May 25, 2021
Was observing behavior where 7zip was nowhere to be found after a build
was completed. Let's just have 7zip be installed within the workflow as
well just to be completely sure 7zip is there.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

ghstack-source-id: 0925994
Pull Request resolved: #58924
@seemethere seemethere requested a review from a team May 25, 2021 16:52
@seemethere seemethere added module: ci Related to continuous integration module: windows Windows support for PyTorch labels May 25, 2021
@seemethere
Copy link
Member Author

@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@driazati
Copy link
Contributor

Just curious what’s 7zip used for? Power shell can do unzips natively and there’s also tar.exe on newer Windows 10s

@seemethere
Copy link
Member Author

Just curious what’s 7zip used for? Power shell can do unzips natively and there’s also tar.exe on newer Windows 10s

We use it as part of build_pytorch.bat here:

python setup.py install --cmake && sccache --show-stats && (
if "%BUILD_ENVIRONMENT%"=="" (
echo NOTE: To run `import torch`, please make sure to activate the conda environment by running `call %CONDA_PARENT_DIR%\Miniconda3\Scripts\activate.bat %CONDA_PARENT_DIR%\Miniconda3` in Command Prompt before running Git Bash.
) else (
7z a %TMP_DIR_WIN%\%IMAGE_COMMIT_TAG%.7z %CONDA_PARENT_DIR%\Miniconda3\Lib\site-packages\torch %CONDA_PARENT_DIR%\Miniconda3\Lib\site-packages\caffe2 && copy /Y "%TMP_DIR_WIN%\%IMAGE_COMMIT_TAG%.7z" "%PYTORCH_FINAL_PACKAGE_DIR%\"
:: export test times so that potential sharded tests that'll branch off this build will use consistent data
python test/run_test.py --export-past-test-times %PYTORCH_FINAL_PACKAGE_DIR%/.pytorch-test-times
)
)

But perhaps that's not actually necessary and we should just defer to powershell's builtins

@facebook-github-bot
Copy link
Contributor

@seemethere merged this pull request in ec89bf6.

@facebook-github-bot facebook-github-bot deleted the gh/seemethere/94/head branch May 29, 2021 14:17
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
Summary:
Pull Request resolved: pytorch#58924

Was observing behavior where 7zip was nowhere to be found after a build
was completed. Let's just have 7zip be installed within the workflow as
well just to be completely sure 7zip is there.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: samestep

Differential Revision: D28681241

Pulled By: seemethere

fbshipit-source-id: f649c1713edcdeb82c84fd67866700caa2726d71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: ci Related to continuous integration module: windows Windows support for PyTorch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants