-
Notifications
You must be signed in to change notification settings - Fork 25.6k
.github: Ensure 7zip install for windows #58924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Was observing behavior where 7zip was nowhere to be found after a build was completed. Let's just have 7zip be installed within the workflow as well just to be completely sure 7zip is there. Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 7415c7e (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Just curious what’s 7zip used for? Power shell can do unzips natively and there’s also tar.exe on newer Windows 10s |
We use it as part of pytorch/.jenkins/pytorch/win-test-helpers/build_pytorch.bat Lines 115 to 124 in bf269fd
But perhaps that's not actually necessary and we should just defer to powershell's builtins |
@seemethere merged this pull request in ec89bf6. |
Summary: Pull Request resolved: pytorch#58924 Was observing behavior where 7zip was nowhere to be found after a build was completed. Let's just have 7zip be installed within the workflow as well just to be completely sure 7zip is there. Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: samestep Differential Revision: D28681241 Pulled By: seemethere fbshipit-source-id: f649c1713edcdeb82c84fd67866700caa2726d71
Stack from ghstack:
Was observing behavior where 7zip was nowhere to be found after a build
was completed. Let's just have 7zip be installed within the workflow as
well just to be completely sure 7zip is there.
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Differential Revision: D28681241