[DataLoader] Close byte stream explicitly #58938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 2ad6a79 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. [ghstack-poisoned]
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. Differential Revision: [D28689862](https://our.internmc.facebook.com/intern/diff/D28689862) [ghstack-poisoned]
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. Differential Revision: [D28689862](https://our.internmc.facebook.com/intern/diff/D28689862) [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. Differential Revision: [D28689862](https://our.internmc.facebook.com/intern/diff/D28689862) [ghstack-poisoned]
|
On a side note: we should document somewhere that it is the users responsibility to close the opened file handles if he doesn't use the builtin decoder. |
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. Differential Revision: [D28689862](https://our.internmc.facebook.com/intern/diff/D28689862) [ghstack-poisoned]
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. Differential Revision: [D28689862](https://our.internmc.facebook.com/intern/diff/D28689862) [ghstack-poisoned]
When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. Differential Revision: [D28689862](https://our.internmc.facebook.com/intern/diff/D28689862) [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#58938 When run `test_datapipe.py`, python `gc` would report lots of `ResourceWarning`s due to unclosed stream. It's not only annoying, there are two potential problems: - Performance regression because `gc` requires additional memory and computation to track reference - Python `gc` runs periodically so we many encountered an error of too many open files due to OS limitation To reduce the warning: - Explicitly close byte stream - Modify `test_datapipe.py` to use context manager Small fix: - Reorder import in `test_datapipe.py` Further investigation: Can we directly use context manager in `LoadFileFromDisk` and `ReadFileFromTar` to eliminate this Error? - Probably no. It's feasible only if the pipeline is synchronized and without prefetching. When we enable these two features, the scope guard of the context manager doesn't work. - We may need to implement some reference counter attached to these file byte stream to close by itself. Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D28689862 Pulled By: ejguan fbshipit-source-id: bb2a85defb8a4ab5384db902ef6ad062185c2653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
When run
test_datapipe.py, pythongcwould report lots ofResourceWarnings due to unclosed stream. It's not only annoying, there are two potential problems:gcrequires additional memory and computation to track referencegcruns periodically so we many encountered an error of too many open files due to OS limitationTo reduce the warning:
test_datapipe.pyto use context managerSmall fix:
test_datapipe.pyFurther investigation:
Can we directly use context manager in
LoadFileFromDiskandReadFileFromTarto eliminate this Error?Differential Revision: D28689862