[quant][refactor tests] Clean up test_quantization.py #59088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Clean up comments and organize the tests better Test Plan: python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 11283f5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@supriyar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Clean up comments and organize the tests better Test Plan: python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28750064](https://our.internmc.facebook.com/intern/diff/D28750064) [ghstack-poisoned]
jerryzh168
reviewed
May 27, 2021
Comment on lines
14
to
15
| from quantization.core.test_quantized_op import TestQNNPackOps # noqa: F401 | ||
| from quantization.core.test_quantized_op import TestQuantizedLinear # noqa: F401 |
There was a problem hiding this comment.
I feel ideally we should merge these into TestQuantizedOps actually.
There was a problem hiding this comment.
Yeah I think we can have a unified class for all ops. I'll add a todo
jerryzh168
approved these changes
May 27, 2021
|
@supriyar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 886a2dd. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#59088 Clean up comments and organize the tests better Test Plan: python test/test_quantization.py Imported from OSS Reviewed By: jerryzh168 Differential Revision: D28750064 fbshipit-source-id: 4c36922e25e3adea3aaa8b4d9185dc28b17aa57c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Clean up comments and organize the tests better
Test Plan:
python test/test_quantization.py
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D28750064