To add Nesterov Adam algorithm for multi-tensor optimizers API #59165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 6c0595d (more details on the Dr. CI page and at hud.pytorch.org/pr/59165):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
iramazanli
changed the title
iramazanli
changed the title
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
15 times, most recently
from
be6e6e0 to
2f603a3
Compare
iramazanli
changed the title
vincentqb
reviewed
Jun 15, 2021
torch/optim/_functional.py
Outdated
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
7 times, most recently
from
3fdae58 to
60c0f39
Compare
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
from
51e8b50 to
284ba60
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
vincentqb
approved these changes
Jun 25, 2021
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
3 times, most recently
from
5039362 to
9d423a5
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
from
9d423a5 to
4093d27
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
2 times, most recently
from
9a19faf to
569c777
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
from
569c777 to
f68a9e2
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
4 times, most recently
from
5f80cc1 to
cd97229
Compare
iramazanli
force-pushed
the
adding_multitensor_nadam
branch
from
cd97229 to
6c0595d
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@iramazanli merged this pull request in f0e972a. |
asuhan
pushed a commit
to asuhan/pytorch
that referenced
this pull request
Jun 28, 2021
…ch#59165) Summary: Previously in the PR: pytorch#59009 we added NAdam to Optimizers. Here in this PR we are proposing multi-tensor version of NAdam for PyTorch. Nadam has been proposed in the paper https://openreview.net/forum?id=OM0jvwB8jIp57ZJjtNEZ and report and report : http://cs229.stanford.edu/proj2015/054_report.pdf by Timothy Dozat. It has been one of the most used algorithm in Deep Learning community. It worth to noting that the implementation of NAdam is inspired by the implementation for Keras : https://github.com/tensorflow/tensorflow/blob/f9d386849581d15d72f6f1f96f12aac230a8edbe/tensorflow/python/keras/optimizer_v2/nadam.py Pull Request resolved: pytorch#59165 Reviewed By: vincentqb Differential Revision: D29360577 Pulled By: iramazanli fbshipit-source-id: 0fe14016303b2df2cb8cc31912a2674acf63d1e5
asuhan
pushed a commit
that referenced
this pull request
Jun 30, 2021
Summary: Previously in the PR: #59009 we added NAdam to Optimizers. Here in this PR we are proposing multi-tensor version of NAdam for PyTorch. Nadam has been proposed in the paper https://openreview.net/forum?id=OM0jvwB8jIp57ZJjtNEZ and report and report : http://cs229.stanford.edu/proj2015/054_report.pdf by Timothy Dozat. It has been one of the most used algorithm in Deep Learning community. It worth to noting that the implementation of NAdam is inspired by the implementation for Keras : https://github.com/tensorflow/tensorflow/blob/f9d386849581d15d72f6f1f96f12aac230a8edbe/tensorflow/python/keras/optimizer_v2/nadam.py Pull Request resolved: #59165 Reviewed By: vincentqb Differential Revision: D29360577 Pulled By: iramazanli fbshipit-source-id: 0fe14016303b2df2cb8cc31912a2674acf63d1e5
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the PR: #59009 we added NAdam to Optimizers. Here in this PR we are proposing multi-tensor version of NAdam for PyTorch.
Nadam has been proposed in the paper https://openreview.net/forum?id=OM0jvwB8jIp57ZJjtNEZ and report and report : http://cs229.stanford.edu/proj2015/054_report.pdf by Timothy Dozat.
It has been one of the most used algorithm in Deep Learning community.
It worth to noting that the implementation of NAdam is inspired by the implementation for Keras :
https://github.com/tensorflow/tensorflow/blob/f9d386849581d15d72f6f1f96f12aac230a8edbe/tensorflow/python/keras/optimizer_v2/nadam.py