[PyTorch][vulkan] Unify convert as vTensor& convert(const Tensor&)
#59268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason we can't give `convert` this signature: `Tensor::unsafeGetTensorImpl() cocnst ` returns a non-const TensorImpl pointer. (See zdevito/ATen#27 (comment)) Differential Revision: [D28811477](https://our.internmc.facebook.com/intern/diff/D28811477/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 44b8bbe (more details on the Dr. CI page):
3 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 1, 2021
AshkanAliabadi
approved these changes
Jun 2, 2021
… Tensor&)`" There's no reason we can't give `convert` this signature: `Tensor::unsafeGetTensorImpl() cocnst ` returns a non-const TensorImpl pointer. (See zdevito/ATen#27 (comment)) Differential Revision: [D28811477](https://our.internmc.facebook.com/intern/diff/D28811477/) [ghstack-poisoned]
|
This pull request has been merged in dce8697. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
…ytorch#59268) Summary: Pull Request resolved: pytorch#59268 There's no reason we can't give `convert` this signature: `Tensor::unsafeGetTensorImpl() cocnst ` returns a non-const TensorImpl pointer. (See zdevito/ATen#27 (comment)) ghstack-source-id: 130548716 Test Plan: CI Reviewed By: SS-JIA Differential Revision: D28811477 fbshipit-source-id: 269f58980c1f68b29d4be3cba4cd340299ce39af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
vTensor& convert(const Tensor&)#59268 [PyTorch][vulkan] Unify convert asvTensor& convert(const Tensor&)There's no reason we can't give
convertthis signature:Tensor::unsafeGetTensorImpl() cocnstreturns a non-const TensorImpl pointer. (See zdevito/ATen#27 (comment))Differential Revision: D28811477