Fix CUDA sync when switching streams in RPC tests #59297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit 2dd6e82 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 2, 2021
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
This was referenced Jun 3, 2021
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. Differential Revision: [D28832902](https://our.internmc.facebook.com/intern/diff/D28832902/) [ghstack-poisoned]
|
This pull request has been merged in 3e7396f. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#59297 PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it. Also, the usage of an Event can be simplified by using `s1.wait(s2)`. ghstack-source-id: 130583777 Test Plan: CI Reviewed By: mrshenli Differential Revision: D28832902 fbshipit-source-id: cd4f40ff811fa1b0042deedda2456e22f33b92bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
PyTorch requires users to manually record tensors with the CUDA caching allocator when switching streams. We weren't doing it.
Also, the usage of an Event can be simplified by using
s1.wait(s2).Differential Revision: D28832902