Skip to content

Using meta checks for unary torch.all and torch.any. #59373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Using meta checks for unary torch.all and torch.any. #59373

wants to merge 7 commits into from

Conversation

ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Jun 3, 2021 •
edited by ezyang
Loading

Stack from ghstack:

This PR makes use of the newly implemented unified at::meta::check_reduction for
validating the inputs and configuring its TensorIterator.

Differential Revision: D29104398

@ysiraichi
Using meta checks for unary torch.all and torch.any.
9e8e441 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

[ghstack-poisoned]
This was referenced Jun 3, 2021
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 3, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 660459f (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ysiraichi added a commit that referenced this pull request Jun 3, 2021
@ysiraichi
Using meta checks for unary torch.all and torch.any.
1aa4602 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

ghstack-source-id: d1a9e9a
Pull Request resolved: #59373
@ysiraichi ysiraichi mentioned this pull request Jun 4, 2021
Closed
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
c0e06c7 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

[ghstack-poisoned]
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
d451241 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 8, 2021
@ysiraichi
Using meta checks for unary torch.all and torch.any.
fe9737f 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

ghstack-source-id: 0a85628
Pull Request resolved: #59373
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
acf570e 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

[ghstack-poisoned]
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
0a719d2 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 9, 2021
@ysiraichi
Using meta checks for unary torch.all and torch.any.
ab9c479 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

ghstack-source-id: 0a85628
Pull Request resolved: #59373
@ysiraichi ysiraichi marked this pull request as ready for review June 9, 2021 13:05
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
eff39b9 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

[ghstack-poisoned]
This was referenced Jun 14, 2021
Closed
Closed
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
660459f 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

[ghstack-poisoned]
@ezyang
Copy link
Contributor

ezyang commented Jun 14, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in c078cef.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 81baa7f.

@ysiraichi ysiraichi deleted the gh/ysiraichi/4/head branch June 21, 2021 11:05
ysiraichi added a commit that referenced this pull request Jun 22, 2021
@ysiraichi
Update on "Port all kernel to structured kernels."
db6d615 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265856](https://our.internmc.facebook.com/intern/diff/D29265856)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 22, 2021
@ysiraichi
Update base for Update on "Port argmin kernel to structured kernels."
6333000 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 22, 2021
@ysiraichi
Update base for Update on "Port argmax to structured kernels."
51c6eb2 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 22, 2021
@ysiraichi
Update on "Port argmax to structured kernels."
c77d694 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 22, 2021
@ysiraichi
Update on "Port argmin kernel to structured kernels."
7927ca3 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 22, 2021
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
4f4ee22 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265858](https://our.internmc.facebook.com/intern/diff/D29265858)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 22, 2021
@ysiraichi
Update on "Port any kernel to structured kernels."
22e5309 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265859](https://our.internmc.facebook.com/intern/diff/D29265859)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2021
@ysiraichi @facebook-github-bot
Port all kernel to structured kernels. (#60360)
a5aa940 
Summary:
Pull Request resolved: #60360

Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D29265856

Pulled By: ezyang

fbshipit-source-id: 6e9b45ad3fc3852bb142ae2e3d58fc5d0a911aed
facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2021
@ysiraichi @facebook-github-bot
Port any kernel to structured kernels. (#60361)
5fd45b8 
Summary:
Pull Request resolved: #60361

Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D29265859

Pulled By: ezyang

fbshipit-source-id: 0cca0431569f38a168473b5cc572ced473799961
ezyang added a commit that referenced this pull request Jun 28, 2021
@ezyang
Update base for Update on "Port argmax to structured kernels."
dca497f 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 28, 2021
@ezyang
Update base for Update on "Port argmin kernel to structured kernels."
cc5a0fc 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 28, 2021
@ezyang
Update base for Update on "Using meta checks for unary torch.all an…
b519fda 
…d `torch.any`."


This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265858](https://our.internmc.facebook.com/intern/diff/D29265858)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 28, 2021
@ezyang
Update on "Port argmin kernel to structured kernels."
cec656e 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 28, 2021
@ezyang
Update on "Using meta checks for unary torch.all and torch.any."
b49e89e 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265858](https://our.internmc.facebook.com/intern/diff/D29265858)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 28, 2021
@ezyang
Update on "Port argmax to structured kernels."
291970e 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 29, 2021
@ysiraichi
Update base for Update on "Port argmin kernel to structured kernels."
dafc6d1 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 29, 2021
@ysiraichi
Update on "Port argmin kernel to structured kernels."
da2c9f2 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 29, 2021
@ysiraichi
Update base for Update on "Port argmax to structured kernels."
107ee13 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 29, 2021
@ysiraichi
Update base for Update on "Using meta checks for unary torch.all an…
086624c 
…d `torch.any`."


This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265858](https://our.internmc.facebook.com/intern/diff/D29265858)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 29, 2021
@ysiraichi
Update on "Using meta checks for unary torch.all and torch.any."
8e0d3dc 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265858](https://our.internmc.facebook.com/intern/diff/D29265858)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 29, 2021
@ysiraichi
Update on "Port argmax to structured kernels."
7aaf860 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 29, 2021
@ezyang
Update base for Update on "Port argmax to structured kernels."
a962509 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 29, 2021
@ezyang
Update base for Update on "Using meta checks for unary torch.all an…
2ed4766 
…d `torch.any`."


This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265858](https://our.internmc.facebook.com/intern/diff/D29265858)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 29, 2021
@ezyang
Update base for Update on "Port argmin kernel to structured kernels."
1c9f11a 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 29, 2021
@ezyang
Update on "Port argmax to structured kernels."
efdea25 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265857](https://our.internmc.facebook.com/intern/diff/D29265857)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 29, 2021
@ezyang
Update on "Using meta checks for unary torch.all and torch.any."
4daddbf 
This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265858](https://our.internmc.facebook.com/intern/diff/D29265858)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 29, 2021
@ezyang
Update on "Port argmin kernel to structured kernels."
1348eb9 
Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Differential Revision: [D29265855](https://our.internmc.facebook.com/intern/diff/D29265855)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jun 29, 2021
@ysiraichi @facebook-github-bot
Using meta checks for unary torch.all and torch.any. (#60362)
df47fa5 
Summary:
Pull Request resolved: #60362

This PR makes use of the newly implemented unified `at::meta::check_reduction` for
validating the inputs and configuring its `TensorIterator`.

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D29265858

Pulled By: ezyang

fbshipit-source-id: e8961b7da65a31acfed5ac3f5c1f5985ae81ec37
facebook-github-bot pushed a commit that referenced this pull request Jun 29, 2021
@ysiraichi @facebook-github-bot
Port argmax to structured kernels. (#60363)
3e22338 
Summary:
Pull Request resolved: #60363

Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D29265857

Pulled By: ezyang

fbshipit-source-id: 586914d2aa79028c56988896093945755a2b9781
facebook-github-bot pushed a commit that referenced this pull request Jun 29, 2021
@ysiraichi @facebook-github-bot
Port argmin kernel to structured kernels. (#60364)
b099f54 
Summary:
Pull Request resolved: #60364

Tracking issue: #55070

This PR was openned so as to solve the CI failures in main when merging: #59371 #59372 #59373 #59937 #59938.

Test Plan: Imported from OSS

Reviewed By: anjali411

Differential Revision: D29265855

Pulled By: ezyang

fbshipit-source-id: ccee3810940542f8b370596105826c96b32231ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ysiraichi @facebook-github-bot @ezyang @pytorchbot