irange for PyTorch sans jit #59481

r-barnes · 2021-06-04T20:54:12Z

Differential Revision: D28909681

facebook-github-bot · 2021-06-04T20:54:21Z

💊 CI failures summary and remediations

As of commit 217746f (more details on the Dr. CI page):

6/9 failures possibly* introduced in this PR
- 1/6 non-scanned failure(s)
3/9 broken upstream at merge base 528d82d on Jun 08 from 1:00pm to 6:03pm

🕵️ 5 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_test (1/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 08 23:53:36 AssertionError: NotImplementedE...orward AD, you should set supports_forward_ad=True

Jun 08 23:53:36 ======================================================================
Jun 08 23:53:36 FAIL [0.006s]: test_forward_mode_AD_outer_cpu_float64 (__main__.TestGradientsCPU)
Jun 08 23:53:36 ----------------------------------------------------------------------
Jun 08 23:53:36 Traceback (most recent call last):
Jun 08 23:53:36   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test
Jun 08 23:53:36     result = test_fn(self, *args)
Jun 08 23:53:36   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 266, in test_wrapper
Jun 08 23:53:36     return test(*args, **kwargs)
Jun 08 23:53:36   File "test_ops.py", line 228, in test_forward_mode_AD
Jun 08 23:53:36     self._grad_test_helper(device, dtype, op, op.get_op(), check_forward_ad=True)
Jun 08 23:53:36 AssertionError: NotImplementedError not raised : Running forward AD for an OP that has does not support it did not raise any error. If your op supports forward AD, you should set supports_forward_ad=True
Jun 08 23:53:36 
Jun 08 23:53:37 ----------------------------------------------------------------------
Jun 08 23:53:37 Ran 9487 tests in 906.891s
Jun 08 23:53:37 
Jun 08 23:53:37 FAILED (failures=2, skipped=1804)
Jun 08 23:53:37 
Jun 08 23:53:37 Generating XML reports...
Jun 08 23:53:37 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestCommonCPU-20210608233829.xml
Jun 08 23:53:37 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestGradientsCPU-20210608233829.xml
Jun 08 23:53:37 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestOpInfoCPU-20210608233829.xml

pytorch_macos_10_13_py3_test (2/5)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 09 00:37:46 AssertionError: NotImplementedE...orward AD, you should set supports_forward_ad=True

Jun 09 00:37:46 ======================================================================
Jun 09 00:37:46 FAIL [0.006s]: test_forward_mode_AD_outer_cpu_float64 (__main__.TestGradientsCPU)
Jun 09 00:37:46 ----------------------------------------------------------------------
Jun 09 00:37:46 Traceback (most recent call last):
Jun 09 00:37:46   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test
Jun 09 00:37:46     result = test_fn(self, *args)
Jun 09 00:37:46   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 266, in test_wrapper
Jun 09 00:37:46     return test(*args, **kwargs)
Jun 09 00:37:46   File "test_ops.py", line 228, in test_forward_mode_AD
Jun 09 00:37:46     self._grad_test_helper(device, dtype, op, op.get_op(), check_forward_ad=True)
Jun 09 00:37:46 AssertionError: NotImplementedError not raised : Running forward AD for an OP that has does not support it did not raise any error. If your op supports forward AD, you should set supports_forward_ad=True
Jun 09 00:37:46 
Jun 09 00:37:46 ----------------------------------------------------------------------
Jun 09 00:37:46 Ran 9487 tests in 1134.209s
Jun 09 00:37:46 
Jun 09 00:37:46 FAILED (failures=2, skipped=1804)
Jun 09 00:37:46 
Jun 09 00:37:46 Generating XML reports...
Jun 09 00:37:46 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestCommonCPU-20210609001851.xml
Jun 09 00:37:47 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestGradientsCPU-20210609001851.xml
Jun 09 00:37:48 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestOpInfoCPU-20210609001851.xml

pytorch_linux_xenial_py3_clang5_asan_test1 (3/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 09 01:13:51 AssertionError: NotImplementedE...orward AD, you should set supports_forward_ad=True

Jun 09 01:13:51 ======================================================================
Jun 09 01:13:51 FAIL [0.020s]: test_forward_mode_AD_outer_cpu_float64 (__main__.TestGradientsCPU)
Jun 09 01:13:51 ----------------------------------------------------------------------
Jun 09 01:13:51 Traceback (most recent call last):
Jun 09 01:13:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test
Jun 09 01:13:51     result = test_fn(self, *args)
Jun 09 01:13:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 266, in test_wrapper
Jun 09 01:13:51     return test(*args, **kwargs)
Jun 09 01:13:51   File "test_ops.py", line 228, in test_forward_mode_AD
Jun 09 01:13:51     self._grad_test_helper(device, dtype, op, op.get_op(), check_forward_ad=True)
Jun 09 01:13:51 AssertionError: NotImplementedError not raised : Running forward AD for an OP that has does not support it did not raise any error. If your op supports forward AD, you should set supports_forward_ad=True
Jun 09 01:13:51 
Jun 09 01:13:53 ----------------------------------------------------------------------
Jun 09 01:13:53 Ran 9487 tests in 4280.836s
Jun 09 01:13:53 
Jun 09 01:13:53 FAILED (failures=2, skipped=1804)
Jun 09 01:13:53 
Jun 09 01:13:53 Generating XML reports...
Jun 09 01:13:53 Generated XML report: test-reports/python-unittest/test_ops/TEST-TestCommonCPU-20210609000230.xml
Jun 09 01:13:53 Generated XML report: test-reports/python-unittest/test_ops/TEST-TestGradientsCPU-20210609000230.xml
Jun 09 01:13:53 Generated XML report: test-reports/python-unittest/test_ops/TEST-TestOpInfoCPU-20210609000230.xml

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1 (4/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 09 01:15:00 AssertionError: NotImplementedE...orward AD, you should set supports_forward_ad=True

Jun 09 01:15:00   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_utils.py", line 1034, in wrapper
Jun 09 01:15:00     method(*args, **kwargs)
Jun 09 01:15:00   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_utils.py", line 1034, in wrapper
Jun 09 01:15:00     method(*args, **kwargs)
Jun 09 01:15:00   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test
Jun 09 01:15:00     result = test_fn(self, *args)
Jun 09 01:15:00   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_device_type.py", line 266, in test_wrapper
Jun 09 01:15:00     return test(*args, **kwargs)
Jun 09 01:15:00   File "/var/lib/jenkins/workspace/test/test_ops.py", line 228, in test_forward_mode_AD
Jun 09 01:15:00     self._grad_test_helper(device, dtype, op, op.get_op(), check_forward_ad=True)
Jun 09 01:15:00 AssertionError: NotImplementedError not raised : Running forward AD for an OP that has does not support it did not raise any error. If your op supports forward AD, you should set supports_forward_ad=True
Jun 09 01:15:00 
Jun 09 01:15:00 ----------------------------------------------------------------------
Jun 09 01:15:00 Ran 9565 tests in 2004.996s
Jun 09 01:15:00 
Jun 09 01:15:00 FAILED (failures=2, errors=1, skipped=1816)
Jun 09 01:15:00 
Jun 09 01:15:00 Generating XML reports...
Jun 09 01:15:00 Generated XML report: test-reports/dist-gloo/.var.lib.jenkins.workspace.test.test_ops/TEST-TestCommonCUDA-20210609004135.xml
Jun 09 01:15:01 Generated XML report: test-reports/dist-gloo/.var.lib.jenkins.workspace.test.test_ops/TEST-TestGradientsCUDA-20210609004135.xml
Jun 09 01:15:01 Generated XML report: test-reports/dist-gloo/.var.lib.jenkins.workspace.test.test_ops/TEST-TestOpInfoCUDA-20210609004135.xml

pytorch_linux_bionic_py3_6_clang9_noarch_test (5/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 09 00:36:23 AssertionError: NotImplementedE...orward AD, you should set supports_forward_ad=True

Jun 09 00:36:23 ======================================================================
Jun 09 00:36:23 FAIL [0.006s]: test_forward_mode_AD_outer_cpu_float64 (__main__.TestGradientsCPU)
Jun 09 00:36:23 ----------------------------------------------------------------------
Jun 09 00:36:23 Traceback (most recent call last):
Jun 09 00:36:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test
Jun 09 00:36:23     result = test_fn(self, *args)
Jun 09 00:36:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 266, in test_wrapper
Jun 09 00:36:23     return test(*args, **kwargs)
Jun 09 00:36:23   File "test_ops.py", line 228, in test_forward_mode_AD
Jun 09 00:36:23     self._grad_test_helper(device, dtype, op, op.get_op(), check_forward_ad=True)
Jun 09 00:36:23 AssertionError: NotImplementedError not raised : Running forward AD for an OP that has does not support it did not raise any error. If your op supports forward AD, you should set supports_forward_ad=True
Jun 09 00:36:23 
Jun 09 00:36:26 ----------------------------------------------------------------------
Jun 09 00:36:26 Ran 18858 tests in 849.775s
Jun 09 00:36:26 
Jun 09 00:36:26 FAILED (failures=2, skipped=11174)
Jun 09 00:36:26 
Jun 09 00:36:26 Generating XML reports...
Jun 09 00:36:26 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestCommonCPU-20210609002213.xml
Jun 09 00:36:26 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestCommonMETA-20210609002213.xml
Jun 09 00:36:26 Generated XML report: test-reports/dist-gloo/test_ops/TEST-TestGradientsCPU-20210609002213.xml

2 jobs timed out:

pytorch_macos_10_13_py3_test
pytorch_linux_bionic_py3_6_clang9_noarch_test

🚧 3 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Windows CI (pytorch-win-vs2019-cpu-py3) / test on Jun 08 from 2:42pm to 3:38pm (1bb1a9e - 6ca141f)
- 🔁 rerun
pytorch_linux_bionic_py3_8_gcc9_coverage_test2 on Jun 08 from 2:18pm to 4:07pm (40cbf34 - d0e84c2)
- 🔁 rerun
pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_test1 on Jun 08 from 1:00pm to 6:03pm (58348be - 6ca141f)
- 🔁 rerun

ci.pytorch.org: 1 failed

Failed: pr/pytorch-linux-bionic-rocm4.2-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2021-06-04T20:54:33Z

This pull request was exported from Phabricator. Differential Revision: D28909681

cbalioglu · 2021-06-07T16:02:37Z

CI is mostly green. Since the PR is fairly large, I just skimmed through it. Besides introducing range based loops are there any behavioral changes? And just out of curiosity; did you use some sed/awk magic or did you make the changes manually?

facebook-github-bot · 2021-06-07T21:53:33Z

This pull request was exported from Phabricator. Differential Revision: D28909681

facebook-github-bot · 2021-06-07T22:57:20Z

This pull request was exported from Phabricator. Differential Revision: D28909681

Summary: Pull Request resolved: pytorch#59481 Differential Revision: D28909681 fbshipit-source-id: a189f103a06ed2f5078dd65e28bdba8cf9d23405

facebook-github-bot · 2021-06-08T22:12:18Z

This pull request was exported from Phabricator. Differential Revision: D28909681

facebook-github-bot · 2021-06-09T21:47:58Z

This pull request has been merged in e3d75b8.

r-barnes requested review from H-Huang, albanD, cbalioglu, mingzhe09088, mrshenli, pritamdamania87, rohan-varma, soulitzer, wayi1 and zhaojuanmao as code owners June 4, 2021 20:54

facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jun 4, 2021

facebook-github-bot added cla signed fb-exported labels Jun 4, 2021

r-barnes force-pushed the export-D28909681 branch from b58074f to 9fca574 Compare June 7, 2021 21:53

r-barnes force-pushed the export-D28909681 branch from 9fca574 to b1c89eb Compare June 7, 2021 22:57

irange for PyTorch sans jit (pytorch#59481)

217746f

Summary: Pull Request resolved: pytorch#59481 Differential Revision: D28909681 fbshipit-source-id: a189f103a06ed2f5078dd65e28bdba8cf9d23405

r-barnes force-pushed the export-D28909681 branch from b1c89eb to 217746f Compare June 8, 2021 22:12

facebook-github-bot closed this in e3d75b8 Jun 9, 2021

facebook-github-bot added the Merged label Jun 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

irange for PyTorch sans jit #59481

irange for PyTorch sans jit #59481

Uh oh!

r-barnes commented Jun 4, 2021

Uh oh!

facebook-github-bot commented Jun 4, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Jun 4, 2021

Uh oh!

cbalioglu commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 8, 2021

Uh oh!

facebook-github-bot commented Jun 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

irange for PyTorch sans jit #59481

irange for PyTorch sans jit #59481

Uh oh!

Conversation

r-barnes commented Jun 4, 2021

Uh oh!

facebook-github-bot commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 5 new failures recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_test (1/5)

pytorch_macos_10_13_py3_test (2/5)

pytorch_linux_xenial_py3_clang5_asan_test1 (3/5)

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1 (4/5)

pytorch_linux_bionic_py3_6_clang9_noarch_test (5/5)

🚧 3 fixed upstream failures:

ci.pytorch.org: 1 failed

Uh oh!

facebook-github-bot commented Jun 4, 2021

Uh oh!

cbalioglu commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 8, 2021

Uh oh!

facebook-github-bot commented Jun 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

facebook-github-bot commented Jun 4, 2021 •

edited

Loading