Skip to content

Move _PartialWrapper to module scope #59660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move _PartialWrapper to module scope #59660

wants to merge 1 commit into from

Conversation

@kev-zheng
Copy link
Contributor

Differential Revision: D28972991

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 8, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit d388cb9 (more details on the Dr. CI page):

  • 1/4 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
  • 3/4 broken upstream at merge base 04986b9 from Jun 08 until Jun 09

1 job timed out:

  • pytorch_linux_xenial_py3_clang5_asan_test1

🚧 3 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28972991

@kev-zheng kev-zheng mentioned this pull request Jun 8, 2021
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28972991

@kev-zheng @facebook-github-bot
Move _PartialWrapper to module scope (pytorch#59660)
d388cb9 
Summary:
Pull Request resolved: pytorch#59660

Context pytorch#57352

Differential Revision: D28972991

fbshipit-source-id: e7e8d8720dd0c787c4b1c602e1bc4f60b007ca11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28972991

vkuzo
vkuzo approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this! Looks good, CI errors look unrelated.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 61965ab.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@kev-zheng @deniskokarev
Move _PartialWrapper to module scope (pytorch#59660)
a39ab65 
Summary:
Pull Request resolved: pytorch#59660

Context pytorch#57352

Test Plan: Pytorch CI tests

Reviewed By: vkuzo

Differential Revision: D28972991

fbshipit-source-id: efc9dd3e90e18e1cdf27d5ef0f168abd8169bc42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

Assignees

No one assigned

Labels

cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kev-zheng @facebook-github-bot @vkuzo