Refactor embedded_interpreter registration to be friendly to python case #59991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit a323f6a (more details on the Dr. CI page and at hud.pytorch.org/pr/59991):
1 failure not recognized by patterns:
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D28764436 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D28764436 |
wconstab
force-pushed
the
export-D28764436
branch
from
dc62ae8 to
afe7b83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D28764436 |
wconstab
force-pushed
the
export-D28764436
branch
from
afe7b83 to
e06d29c
Compare
…ase (pytorch#59991) Summary: Pull Request resolved: pytorch#59991 add a registration mechanism whereby on loading the embedded interpreter library, a registration function is called which links up the symbols it provides with torch::deploy. Test Plan: local and CI deploy tests pass Reviewed By: suo Differential Revision: D28764436 fbshipit-source-id: 9557cbd7072fb054869e3a945fcc5cff3091894d
|
This pull request was exported from Phabricator. Differential Revision: D28764436 |
wconstab
force-pushed
the
export-D28764436
branch
from
e06d29c to
a323f6a
Compare
|
This pull request has been merged in 6fa80f7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: add a registration mechanism whereby on loading the embedded interpreter library, a registration function is called which links up the symbols it provides with torch::deploy.
Test Plan: local and CI deploy tests pass
Differential Revision: D28764436