mkl_scsrmm needs to be disabled when MKL is not used #60051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 47190f4 (more details on the Dr. CI page and at hud.pytorch.org/pr/60051):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D29022635 |
Codecov Report
@@ Coverage Diff @@
## master #60051 +/- ##
==========================================
- Coverage 80.60% 76.09% -4.51%
==========================================
Files 1879 2047 +168
Lines 202892 204253 +1361
==========================================
- Hits 163543 155435 -8108
- Misses 39349 48818 +9469 |
driazati
approved these changes
Jun 29, 2021
Summary: Pull Request resolved: pytorch#60051 Introduction: We want to minimize the number of dependencies for the SGX port. Therefore we need the ability to disable MKL when it is not used. Problem : There is a call to mkl_scsrmm that is enabled when CAFFE2_USE_MKL is not defined. This causes a compile error. Solution : Surround the call with preprocessor checks to CAFFE2_USE_MKL Test Plan: Run the pytorch tests. Reviewed By: LiJihang Differential Revision: D29022635 fbshipit-source-id: a56ad2e172c6467cd8718b5aeab34343bc8a1bca
|
This pull request was exported from Phabricator. Differential Revision: D29022635 |
dimitrijejankov
force-pushed
the
export-D29022635
branch
from
db02472 to
47190f4
Compare
|
This pull request has been merged in b4496df. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduction:
We want to minimize the number of dependencies for the SGX port. Therefore we need the ability to disable MKL when it is not used.
Problem :
There is a call to mkl_scsrmm that is enabled when CAFFE2_USE_MKL is not defined. This causes a compile error.
Solution :
Surround the call with preprocessor checks to CAFFE2_USE_MKL
Test Plan: Run the pytorch tests.
Differential Revision: D29022635