Skip to content

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Jun 16, 2021

A few more quality of life improvements for NNC's python bindings:

  • Use standard torch.dtypes (rather than te.Dtype)
  • Make names optional (they don't seem to matter)
  • Make shapes optional
  • A few implicit conversions to make code cleaner

Followup to #59920

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jun 16, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 16, 2021

💊 CI failures summary and remediations

As of commit 8507107 (more details on the Dr. CI page):


  • 4/4 failures possibly* introduced in this PR
    • 1/4 non-scanned failure(s)

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_android_ndk_r19c_x86_32_build (1/3)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun)

E: Unable to locate package expect-dev

Reading state information... 0%

Reading state information... 0%

Reading state information... Done

W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Unable to locate package moreutils
E: Unable to locate package expect-dev
+ sudo apt-get -y install moreutils expect-dev

Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done


Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree       


Reading state information... 0%

Reading state information... 0%

Reading state information... Done

W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Unable to locate package moreutils
E: Unable to locate package expect-dev


Exited with code exit status 100

See CircleCI build pytorch_linux_xenial_py3_clang5_mobile_custom_build_dynamic (2/3)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun)

E: Unable to locate package expect-dev

Reading state information... 0%

Reading state information... 0%

Reading state information... Done

W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Unable to locate package moreutils
E: Unable to locate package expect-dev
+ sudo apt-get -y install moreutils expect-dev

Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done


Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree       


Reading state information... 0%

Reading state information... 0%

Reading state information... Done

W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Unable to locate package moreutils
E: Unable to locate package expect-dev


Exited with code exit status 100

See CircleCI build pytorch_linux_xenial_py3_clang5_mobile_custom_build_static (3/3)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun)

E: Unable to locate package expect-dev

Reading state information... 0%

Reading state information... 0%

Reading state information... Done

W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Unable to locate package moreutils
E: Unable to locate package expect-dev
+ sudo apt-get -y install moreutils expect-dev

Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done


Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree       


Reading state information... 0%

Reading state information... 0%

Reading state information... Done

W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Unable to locate package moreutils
E: Unable to locate package expect-dev


Exited with code exit status 100


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jansel jansel force-pushed the bindingstwo202106 branch from a6616af to 0b6c036 Compare June 16, 2021 00:25
@facebook-github-bot
Copy link
Contributor

@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@bertmaher bertmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you, it really cleans up the API a lot.

@bertmaher
Copy link
Contributor

This reminds me that we should go through @Chillee's list (#52434) of usability issues. I think the stuff you fixed here has been on that list for ages :-)

@facebook-github-bot
Copy link
Contributor

@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jansel merged this pull request in 85517a2.

@jansel jansel deleted the bindingstwo202106 branch June 17, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants