Skip to content

Conversation

hlu1
Copy link
Contributor

@hlu1 hlu1 commented Jun 17, 2021

Summary: Remove aten::to from allow_list now that the aten::to schema change has landed (D29121620 (eda2ddb)).

Test Plan: CI

Differential Revision: D29187314

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 17, 2021

💊 CI failures summary and remediations

As of commit 7e24bf7 (more details on the Dr. CI page and at hud.pytorch.org/pr/60147):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 25 01:56:00 AssertionError: False is not tr...lowed difference with rtol=0 and atol=0 is only 0!
Jun 25 01:56:00 ----------------------------------------------------------------------
Jun 25 01:56:00 Traceback (most recent call last):
Jun 25 01:56:00   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 399, in wrapper
Jun 25 01:56:00     self._join_processes(fn)
Jun 25 01:56:00   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 606, in _join_processes
Jun 25 01:56:00     self._check_return_codes(elapsed_time)
Jun 25 01:56:00   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 655, in _check_return_codes
Jun 25 01:56:00     self.assertEqual(
Jun 25 01:56:00   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_utils.py", line 1498, in assertEqual
Jun 25 01:56:00     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
Jun 25 01:56:00 AssertionError: False is not true : Scalars failed to compare as equal! Comparing -6 and 0 gives a difference of 6, but the allowed difference with rtol=0 and atol=0 is only 0!
Jun 25 01:56:00 Expect process 1 exit code to match Process 0 exit code of 0, but got -6
Jun 25 01:56:00 
Jun 25 01:56:00 ----------------------------------------------------------------------
Jun 25 01:56:00 Ran 367 tests in 1404.969s
Jun 25 01:56:00 
Jun 25 01:56:00 FAILED (failures=1, skipped=7)
Jun 25 01:56:00 
Jun 25 01:56:00 Generating XML reports...
Jun 25 01:56:00 Generated XML report: test-reports/python-unittest/distributed.rpc.test_tensorpipe_agent/TEST-TensorPipeDdpComparisonTestWithSpawn-20210625013235.xml
Jun 25 01:56:00 Generated XML report: test-reports/python-unittest/distributed.rpc.test_tensorpipe_agent/TEST-TensorPipeDdpUnderDistAutogradTestWithSpawn-20210625013235.xml

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test2 (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 25 02:43:41 RuntimeError: test_unary_ufuncs failed!
Jun 25 02:43:41     #172 0x55bf83d43196 in main /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Programs/python.c:69
Jun 25 02:43:41     #173 0x7f74cf4f783f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
Jun 25 02:43:41     #174 0x55bf83dd333d in _start (/opt/conda/bin/python3.6+0x1a733d)
Jun 25 02:43:41 
Jun 25 02:43:41 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/native/Math.h:217:17 in 
Jun 25 02:43:41 Traceback (most recent call last):
Jun 25 02:43:41   File "test/run_test.py", line 1310, in <module>
Jun 25 02:43:41     main()
Jun 25 02:43:41   File "test/run_test.py", line 1289, in main
Jun 25 02:43:41     raise RuntimeError(err_message)
Jun 25 02:43:41 RuntimeError: test_unary_ufuncs failed!
Jun 25 02:43:42 + cleanup
Jun 25 02:43:42 + retcode=1
Jun 25 02:43:42 + set +x
Jun 25 02:43:42 =================== sccache compilation log ===================
Jun 25 02:43:42 =========== If your build fails, please take a look at the log above for possible reasons ===========
Jun 25 02:43:42 Compile requests                      2
Jun 25 02:43:42 Compile requests executed             0
Jun 25 02:43:42 Cache hits                            0
Jun 25 02:43:42 Cache misses                          0
Jun 25 02:43:42 Cache timeouts                        0

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D29187314

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D29187314

@hlu1 hlu1 force-pushed the export-D29187314 branch from dcfff27 to ec9ee73 Compare June 18, 2021 02:09
@mruberry mruberry self-requested a review June 20, 2021 08:38
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this would still break the back compat test. I recommend just letting the entry expire (which will happen naturally in a couple days)

Summary:
Pull Request resolved: pytorch#60147

Remove aten::to from allow_list now that the aten::to schema change has landed (D29121620 (pytorch@eda2ddb)).

Test Plan: CI

Reviewed By: iseeyuan

Differential Revision: D29187314

fbshipit-source-id: 9b0a17f629fd03a146afe3140c7674d11e78d987
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D29187314

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2b51a8a.

iramazanli pushed a commit to iramazanli/pytorch that referenced this pull request Jun 25, 2021
Summary:
Pull Request resolved: pytorch#60147

Remove aten::to from allow_list now that the aten::to schema change has landed (D29121620 (pytorch@eda2ddb)).

Test Plan: CI

Reviewed By: iseeyuan

Differential Revision: D29187314

fbshipit-source-id: abdb5a560287a861f3858732f7b3da342ee4aa55
asuhan pushed a commit to asuhan/pytorch that referenced this pull request Jun 28, 2021
Summary:
Pull Request resolved: pytorch#60147

Remove aten::to from allow_list now that the aten::to schema change has landed (D29121620 (pytorch@eda2ddb)).

Test Plan: CI

Reviewed By: iseeyuan

Differential Revision: D29187314

fbshipit-source-id: abdb5a560287a861f3858732f7b3da342ee4aa55
asuhan pushed a commit that referenced this pull request Jun 30, 2021
Summary:
Pull Request resolved: #60147

Remove aten::to from allow_list now that the aten::to schema change has landed (D29121620 (eda2ddb)).

Test Plan: CI

Reviewed By: iseeyuan

Differential Revision: D29187314

fbshipit-source-id: abdb5a560287a861f3858732f7b3da342ee4aa55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants