Skip to content

Conversation

nikithamalgifb
Copy link
Contributor

Summary:

Adds custom code filter for Torchscript to include tracing of forward calls.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Jun 18, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 18, 2021

💊 CI failures summary and remediations

As of commit 25e2f94 (more details on the Dr. CI page and at hud.pytorch.org/pr/60309):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 21 22:01:28 ERROR [0.005s]: test_poisson_sample (__main__.TestDistributions)
Jun 21 22:01:28   File "distributions/test_distributions.py", line 805, in _check_sampler_discrete
Jun 21 22:01:28     chisq, p = scipy.stats.chisquare(counts[msk], pmf[msk] * num_samples)
Jun 21 22:01:28   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/scipy/stats/stats.py", line 6853, in chisquare
Jun 21 22:01:28     lambda_="pearson")
Jun 21 22:01:28   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/scipy/stats/stats.py", line 6694, in power_divergence
Jun 21 22:01:28     raise ValueError(msg)
Jun 21 22:01:28 ValueError: For each axis slice, the sum of the observed frequencies must agree with the sum of the expected frequencies to a relative tolerance of 1e-08, but the percent differences are:
Jun 21 22:01:28 0.008265582255680495
Jun 21 22:01:28 
Jun 21 22:01:28 ======================================================================
Jun 21 22:01:28 ERROR [0.005s]: test_poisson_sample (__main__.TestDistributions)
Jun 21 22:01:28 ----------------------------------------------------------------------
Jun 21 22:01:28 Traceback (most recent call last):
Jun 21 22:01:28   File "distributions/test_distributions.py", line 1333, in test_poisson_sample
Jun 21 22:01:28     failure_rate=1e-3)
Jun 21 22:01:28   File "distributions/test_distributions.py", line 805, in _check_sampler_discrete
Jun 21 22:01:28     chisq, p = scipy.stats.chisquare(counts[msk], pmf[msk] * num_samples)
Jun 21 22:01:28   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/scipy/stats/stats.py", line 6853, in chisquare
Jun 21 22:01:28     lambda_="pearson")
Jun 21 22:01:28   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/scipy/stats/stats.py", line 6694, in power_divergence
Jun 21 22:01:28     raise ValueError(msg)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@nikithamalgifb nikithamalgifb requested a review from gmagogsfm June 18, 2021 22:57
@nikithamalgifb nikithamalgifb requested a review from gmagogsfm June 21, 2021 21:27
@facebook-github-bot
Copy link
Contributor

@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@nikithamalgifb merged this pull request in dc9aa7b.

@github-actions github-actions bot deleted the enable_custom_codefilter branch February 12, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants