Skip to content

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Jun 21, 2021

Stack from ghstack:

Disabling the process group backend RPC CI tests running internally and in OSS. This is the first step for retiring ProcessGroup backend for RPC (#55615)

Differential Revision: D29278179

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2021

💊 CI failures summary and remediations

As of commit 5fa8a6a (more details on the Dr. CI page and at hud.pytorch.org/pr/60407):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
  • 1/1 broken upstream at merge base 65f33ec on Jun 21 from 1:29pm to 2:54pm

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@H-Huang H-Huang marked this pull request as draft June 21, 2021 21:34
H-Huang added a commit that referenced this pull request Jun 21, 2021
@H-Huang
Copy link
Member Author

H-Huang commented Jun 21, 2021

@H-Huang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #60407 (5fa8a6a) into gh/H-Huang/25/base (65f33ec) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           gh/H-Huang/25/base   #60407      +/-   ##
======================================================
- Coverage               76.24%   76.17%   -0.07%     
======================================================
  Files                    2053     2053              
  Lines                  205008   205008              
======================================================
- Hits                   156303   156162     -141     
- Misses                  48705    48846     +141     

@mrshenli mrshenli changed the title Disable group group backend rpc tests from running on CI Disable process group backend rpc tests from running on CI Jun 23, 2021
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on retiring PG agent.

@mrshenli
Copy link
Contributor

Closes #60327 #59796 #59792 #50702

@H-Huang H-Huang marked this pull request as ready for review June 23, 2021 16:33
@facebook-github-bot
Copy link
Contributor

@H-Huang merged this pull request in ff3678e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants