Skip to content

Conversation

zhouzhuojie
Copy link
Contributor

Refactor and consolidate the location of lint related workflows

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 29, 2021

💊 CI failures summary and remediations

As of commit 5d259da (more details on the Dr. CI page and at hud.pytorch.org/pr/60918):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@zhouzhuojie zhouzhuojie requested a review from a team June 29, 2021 01:05
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only apply to pull_request, the same setup as the original workflow.

the script tools/linter/clang_format_ci.sh depends on the git diff, and only checks the diff

Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

been wondering for while why this wasn't the case :) thanks!

@facebook-github-bot
Copy link
Contributor

@zhouzhuojie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zhouzhuojie zhouzhuojie force-pushed the move-clang-format-to-lint branch from 7285835 to 5d259da Compare June 29, 2021 23:18
@facebook-github-bot
Copy link
Contributor

@zhouzhuojie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #60918 (5d259da) into master (af66356) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #60918   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files        2062     2062           
  Lines      205602   205602           
=======================================
+ Hits       156793   156796    +3     
+ Misses      48809    48806    -3     

@facebook-github-bot
Copy link
Contributor

@zhouzhuojie merged this pull request in abb4ed7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants