-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Move clang-format to lint.yml #60918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 5d259da (more details on the Dr. CI page and at hud.pytorch.org/pr/60918): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
.github/workflows/lint.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only apply to pull_request
, the same setup as the original workflow.
the script tools/linter/clang_format_ci.sh
depends on the git diff, and only checks the diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
been wondering for while why this wasn't the case :) thanks!
@zhouzhuojie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
7285835
to
5d259da
Compare
@zhouzhuojie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## master #60918 +/- ##
=======================================
Coverage 76.26% 76.26%
=======================================
Files 2062 2062
Lines 205602 205602
=======================================
+ Hits 156793 156796 +3
+ Misses 48809 48806 -3 |
@zhouzhuojie merged this pull request in abb4ed7. |
Refactor and consolidate the location of lint related workflows