Wrapped create_type_hint in try/except block so that NormalizeArgs doesn't fail if create_type_hint fails #61524

Chillee · 2021-07-12T08:17:09Z

Stack from ghstack:

Wrapped create_type_hint in try/except block so that NormalizeArgs doesn't fail if create_type_hint fails #61524 Wrapped create_type_hint in try/except block so that NormalizeArgs doesn't fail if create_type_hint fails

Differential Revision: D29746106

…esn't fail if create_type_hint fails [ghstack-poisoned]

facebook-github-bot · 2021-07-12T08:17:15Z

💊 CI failures summary and remediations

As of commit 80ec6d9 (more details on the Dr. CI page and at hud.pytorch.org/pr/61524):

3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/job-specs-custom.yml
Auto-merging .circleci/verbatim-sources/job-specs/job-specs-custom.yml
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
Auto-merging .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
CONFLICT (add/add): Merge conflict in .circleci/scripts/vs_install.ps1
Auto-merging .circleci/scripts/vs_install.ps1
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_xla_linux_bionic_py3_6_clang9_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/job-specs-custom.yml
Auto-merging .circleci/verbatim-sources/job-specs/job-specs-custom.yml
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
Auto-merging .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
CONFLICT (add/add): Merge conflict in .circleci/scripts/vs_install.ps1
Auto-merging .circleci/scripts/vs_install.ps1
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_macos_10_13_py3_test (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jul 17 00:00:30 test_remote_message_script_de...yUniqueId(created_on=0, local_id=0) to be created.

Jul 16 23:59:56 frame #12: std::__1::__function::__func<std::__1::__bind<torch::distributed::rpc::ProcessGroupAgent::enqueueRecv(torch::distributed::rpc::RecvWork)::$_6, torch::distributed::rpc::RecvWork>, std::__1::allocator<std::__1::__bind<torch::distributed::rpc::ProcessGroupAgent::enqueueRecv(torch::distributed::rpc::RecvWork)::$_6, torch::distributed::rpc::RecvWork> >, void ()>::operator()() + 42 (0x1141b81fa in libtorch_cpu.dylib)
Jul 16 23:59:56 frame #13: c10::ThreadPool::main_loop(unsigned long) + 569 (0x109d14389 in libc10.dylib)
Jul 16 23:59:56 frame #14: void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, c10::ThreadPool::ThreadPool(int, int, std::__1::function<void ()>)::$_0> >(void*) + 67 (0x109d14a33 in libc10.dylib)
Jul 16 23:59:56 frame #15: _pthread_start + 148 (0x7fff6c087109 in libsystem_pthread.dylib)
Jul 16 23:59:56 frame #16: thread_start + 15 (0x7fff6c082b8b in libsystem_pthread.dylib)
Jul 16 23:59:56 
Jul 16 23:59:56 ok (5.395s)
Jul 17 00:00:06   test_remote_message_dropped_pickle (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (9.817s)
Jul 17 00:00:16   test_remote_message_dropped_pickle_to_self (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (9.806s)
Jul 17 00:00:24   test_remote_message_script_delay_timeout (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (8.518s)
Jul 17 00:00:30   test_remote_message_script_delay_timeout_to_self (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... [E request_callback_no_python.cpp:555] Received error while processing request type 260: falseINTERNAL ASSERT FAILED at "../torch/csrc/distributed/rpc/rref_context.cpp":390, please report a bug to PyTorch. Expected OwnerRRef with id GloballyUniqueId(created_on=0, local_id=0) to be created.
Jul 17 00:00:30 Exception raised from getOwnerRRef at ../torch/csrc/distributed/rpc/rref_context.cpp:390 (most recent call first):
Jul 17 00:00:30 frame #0: c10::Error::Error(c10::SourceLocation, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >) + 98 (0x10e6b96d2 in libc10.dylib)
Jul 17 00:00:30 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 106 (0x10e6b7e4a in libc10.dylib)
Jul 17 00:00:30 frame #2: c10::detail::torchInternalAssertFail(char const*, char const*, unsigned int, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 64 (0x10e6b8080 in libc10.dylib)
Jul 17 00:00:30 frame #3: torch::distributed::rpc::RRefContext::getOwnerRRef(torch::distributed::rpc::GloballyUniqueId const&, bool) + 1620 (0x11979b824 in libtorch_cpu.dylib)
Jul 17 00:00:30 frame #4: torch::distributed::rpc::RequestCallbackNoPython::assignOwnerRRef(torch::distributed::rpc::GloballyUniqueId const&, torch::distributed::rpc::GloballyUniqueId const&, c10::intrusive_ptr<c10::ivalue::Future, c10::detail::intrusive_target_default_null_type<c10::ivalue::Future> >) const + 86 (0x119786db6 in libtorch_cpu.dylib)
Jul 17 00:00:30 frame #5: torch::distributed::rpc::RequestCallbackImpl::processScriptRemoteCall(torch::distributed::rpc::RpcCommandBase&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const + 376 (0x11586bbf8 in libtorch_python.dylib)
Jul 17 00:00:30 frame #6: torch::distributed::rpc::RequestCallbackNoPython::processRpc(torch::distributed::rpc::RpcCommandBase&, torch::distributed::rpc::MessageType const&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const + 437 (0x119785a05 in libtorch_cpu.dylib)
Jul 17 00:00:30 frame #7: torch::distributed::rpc::RequestCallbackImpl::processRpcWithErrors(torch::distributed::rpc::RpcCommandBase&, torch::distributed::rpc::MessageType const&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const + 74 (0x11586c96a in libtorch_python.dylib)
Jul 17 00:00:30 frame #8: c10::intrusive_ptr<c10::ivalue::Future, c10::detail::intrusive_target_default_null_type<c10::ivalue::Future> > c10::ivalue::Future::thenAsync<torch::distributed::rpc::RequestCallbackNoPython::processMessage(torch::distributed::rpc::Message&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const::$_1>(torch::distributed::rpc::RequestCallbackNoPython::processMessage(torch::distributed::rpc::Message&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const::$_1, std::__1::shared_ptr<c10::Type>)::'lambda'(c10::ivalue::Future&)::operator()(c10::ivalue::Future&) + 223 (0x11978d5df in libtorch_cpu.dylib)

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…esn't fail if create_type_hint fails ghstack-source-id: 65dbd0e Pull Request resolved: #61524

jamesr66a · 2021-07-12T17:17:32Z

torch/fx/operator_schemas.py

+                    return ret_type(Any)
+            return ret_type(base_type)
+    except Exception as e:
+        # We tried to create a type hint for list but failed.


Do we want to print a warning?

…lizeArgs doesn't fail if create_type_hint fails" [ghstack-poisoned]

…esn't fail if create_type_hint fails ghstack-source-id: d33acb6 Pull Request resolved: #61524

Chillee · 2021-07-16T23:16:14Z

@Chillee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-07-17T23:14:55Z

@Chillee merged this pull request in e117d94.

Wrapped create_type_hint in try/except block so that NormalizeArgs do…

63f4ff1

…esn't fail if create_type_hint fails [ghstack-poisoned]

facebook-github-bot added fx cla signed labels Jul 12, 2021

Chillee added a commit that referenced this pull request Jul 12, 2021

Wrapped create_type_hint in try/except block so that NormalizeArgs do…

451b1d9

…esn't fail if create_type_hint fails ghstack-source-id: 65dbd0e Pull Request resolved: #61524

jamesr66a approved these changes Jul 12, 2021

View reviewed changes

Update on "Wrapped create_type_hint in try/except block so that Norma…

80ec6d9

…lizeArgs doesn't fail if create_type_hint fails" [ghstack-poisoned]

Chillee added a commit that referenced this pull request Jul 16, 2021

Wrapped create_type_hint in try/except block so that NormalizeArgs do…

c0be78e

…esn't fail if create_type_hint fails ghstack-source-id: d33acb6 Pull Request resolved: #61524

facebook-github-bot closed this in e117d94 Jul 17, 2021

facebook-github-bot added the Merged label Jul 17, 2021

facebook-github-bot deleted the gh/chillee/50/head branch July 21, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wrapped create_type_hint in try/except block so that NormalizeArgs doesn't fail if create_type_hint fails #61524

Wrapped create_type_hint in try/except block so that NormalizeArgs doesn't fail if create_type_hint fails #61524

Uh oh!

Chillee commented Jul 12, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Jul 12, 2021 •

edited

Loading

Uh oh!

jamesr66a Jul 12, 2021

Uh oh!

Chillee commented Jul 16, 2021

Uh oh!

facebook-github-bot commented Jul 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Wrapped create_type_hint in try/except block so that NormalizeArgs doesn't fail if create_type_hint fails #61524

Wrapped create_type_hint in try/except block so that NormalizeArgs doesn't fail if create_type_hint fails #61524

Uh oh!

Conversation

Chillee commented Jul 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jul 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 3 new failures recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_build (1/3)

pytorch_xla_linux_bionic_py3_6_clang9_build (2/3)

pytorch_macos_10_13_py3_test (3/3)

Uh oh!

jamesr66a Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

Chillee commented Jul 16, 2021

Uh oh!

facebook-github-bot commented Jul 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Chillee commented Jul 12, 2021 •

edited

Loading

facebook-github-bot commented Jul 12, 2021 •

edited

Loading