Skip to content

[profiler][refactor] Avoid using legacy event in profiler #61721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[profiler][refactor] Avoid using legacy event in profiler #61721

wants to merge 8 commits into from

Conversation

ilia-cher
Copy link
Contributor

@ilia-cher ilia-cher commented Jul 15, 2021 •
edited
Loading

Stack from ghstack:

Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: D29716769

[profiler][refactor] Avoid using legacy event in profiler
fd9689f 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

[ghstack-poisoned]
@ilia-cher ilia-cher mentioned this pull request Jul 15, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 15, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit b493943 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[profiler][refactor] Avoid using legacy event in profiler"
de36f15 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: [D29716769](https://our.internmc.facebook.com/intern/diff/D29716769)

[ghstack-poisoned]
@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[profiler][refactor] Avoid using legacy event in profiler"
e44e925 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: [D29716769](https://our.internmc.facebook.com/intern/diff/D29716769)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jul 15, 2021
[profiler][refactor] Avoid using legacy event in profiler
ea1ac8b 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

ghstack-source-id: da1fd8b
Pull Request resolved: #61721
@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@soulitzer soulitzer removed their request for review July 15, 2021 20:58
Update on "[profiler][refactor] Avoid using legacy event in profiler"
42256df 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: [D29716769](https://our.internmc.facebook.com/intern/diff/D29716769)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jul 16, 2021
[profiler][refactor] Avoid using legacy event in profiler
5bcc2ba 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

ghstack-source-id: 1ff87b3
Pull Request resolved: #61721
@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

guotuofeng
guotuofeng reviewed Jul 17, 2021
View reviewed changes
@albanD albanD removed their request for review July 19, 2021 21:00
Update on "[profiler][refactor] Avoid using legacy event in profiler"
ccb8fdb 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: [D29716769](https://our.internmc.facebook.com/intern/diff/D29716769)

[ghstack-poisoned]
@ilia-cher ilia-cher mentioned this pull request Jul 20, 2021
Closed
@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[profiler][refactor] Avoid using legacy event in profiler"
f79175b 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: [D29716769](https://our.internmc.facebook.com/intern/diff/D29716769)

[ghstack-poisoned]
@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[profiler][refactor] Avoid using legacy event in profiler"
6d394b1 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: [D29716769](https://our.internmc.facebook.com/intern/diff/D29716769)

[ghstack-poisoned]
@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kimishpatel
kimishpatel reviewed Jul 22, 2021
View reviewed changes
kimishpatel
kimishpatel reviewed Jul 22, 2021
View reviewed changes
kimishpatel
kimishpatel reviewed Jul 22, 2021
View reviewed changes
kimishpatel
kimishpatel reviewed Jul 22, 2021
View reviewed changes
kimishpatel
kimishpatel approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left some minor comments.

Update on "[profiler][refactor] Avoid using legacy event in profiler"
b493943 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

Differential Revision: [D29716769](https://our.internmc.facebook.com/intern/diff/D29716769)

[ghstack-poisoned]
@ilia-cher
Copy link
Contributor Author

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 41f7a9d.

QYP-842653 pushed a commit to QYP-842653/Pytorch that referenced this pull request Jul 27, 2021
[profiler][refactor] Avoid using legacy event in profiler
405e8ec 
Summary:
Remove dependency on LegacyEvent from the profiler

Test Plan:
python test/test_profiler.py -v

Reviewers: gdankel

ghstack-source-id: 9796b78
Pull Request resolved: pytorch/pytorch#61721
@facebook-github-bot facebook-github-bot deleted the gh/ilia-cher/91/head branch July 27, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

+1 more reviewer

@guotuofeng guotuofeng guotuofeng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilia-cher @facebook-github-bot @guotuofeng @kimishpatel