Skip to content

Conversation

suo
Copy link
Member

@suo suo commented Jul 17, 2021

These shouldn't be separate files, they test the same thing

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 17, 2021

💊 CI failures summary and remediations

As of commit 9089b38 (more details on the Dr. CI page and at hud.pytorch.org/pr/61807):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

suo added a commit that referenced this pull request Jul 17, 2021
These shouldn't be separate files, they test the same thing

ghstack-source-id: 1ff943a
Pull Request resolved: #61807
@suo
Copy link
Member Author

suo commented Jul 17, 2021

@suo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

These shouldn't be separate files, they test the same thing

Differential Revision: [D29748967](https://our.internmc.facebook.com/intern/diff/D29748967)

[ghstack-poisoned]
@suo
Copy link
Member Author

suo commented Jul 19, 2021

@suo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Lilyjjo Lilyjjo self-requested a review July 19, 2021 18:26
Copy link
Contributor

@Lilyjjo Lilyjjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot better engineering at its finest 🚀

These shouldn't be separate files, they test the same thing

Differential Revision: [D29748967](https://our.internmc.facebook.com/intern/diff/D29748967)

[ghstack-poisoned]
suo added a commit that referenced this pull request Jul 19, 2021
These shouldn't be separate files, they test the same thing

ghstack-source-id: 7343ceb
Pull Request resolved: #61807
@suo
Copy link
Member Author

suo commented Jul 19, 2021

@suo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@suo merged this pull request in 554038c.

@facebook-github-bot facebook-github-bot deleted the gh/suo/448/head branch July 23, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants