[1/N] Avoid skipping tests in sandcastle. #61876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the sandcastle environment, avoid skipping tests and instead just "pass" these tests to avoid a large number of tasks being created which are not actionable. Differential Revision: [D29779699](https://our.internmc.facebook.com/intern/diff/D29779699/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 165f404 (more details on the Dr. CI page and at hud.pytorch.org/pr/61876): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pritamdamania87
pushed a commit
that referenced
this pull request
Jul 19, 2021
In the sandcastle environment, avoid skipping tests and instead just "pass" these tests to avoid a large number of tasks being created which are not actionable. Differential Revision: [D29779699](https://our.internmc.facebook.com/intern/diff/D29779699/) ghstack-source-id: 133846232 Pull Request resolved: #61876
pritamdamania87
requested review from
cbalioglu,
mrshenli,
rohan-varma,
wayi1 and
zhaojuanmao
|
This pull request has been merged in a8f6b5a. |
This was referenced Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In the sandcastle environment, avoid skipping tests and instead just
"pass" these tests to avoid a large number of tasks being created which are not
actionable.
Differential Revision: D29779699