Back out "Revert D29687143: [3/N] Nnapi Backend Delegate Preprocess: Basic OSS Test" #61878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…process: Basic OSS Test" Summary: Using this PR to test CI tests in #61787, since I'm also trying to learn how to debug by rerunning jobs with SSH. Test Plan: Reviewers: Subscribers: myuan Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 96351c4 (more details on the Dr. CI page and at hud.pytorch.org/pr/61878):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
Looks like it has the undefined python symbol issue with Mac build? |
|
@Amyh11325 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…elegate Preprocess: Basic OSS Test"" Summary: Using this PR to test CI tests in #61787, since I'm also trying to learn how to debug by rerunning jobs with SSH. Test Plan: To run NNAPI delegate unit tests: `python test/test_jit.py TestNnapiBackend` Reviewers: Subscribers: myuan Tasks: Tags: Differential Revision: [D29799895](https://our.internmc.facebook.com/intern/diff/D29799895) [ghstack-poisoned]
Amyh11325
changed the title
iseeyuan
approved these changes
Jul 20, 2021
| import torch._C | ||
| from pathlib import Path | ||
|
|
||
| from torch.testing._internal.common_utils import ( |
There was a problem hiding this comment.
Please fix the lint error before landing it.
iseeyuan
requested changes
Jul 20, 2021
| ) | ||
| add_dependencies(torch_python gen_torch_version) | ||
|
|
||
| if(NOT ${CMAKE_SYSTEM_NAME} MATCHES "Darwin") |
There was a problem hiding this comment.
Please submit a github issue and put the issue number in the comment.
…reprocess: Basic OSS Test"" Summary: Android NNAPI delegate library was moved from test/cpp/jit/CMakeLists.txt to torch/CMakeLists.txt. This resolves the issue the original PR had, where the NNAPI delegate library was added to builds without Python (when it depends on Python). Original PR #61594 Test Plan: Ran NNAPI delegate unit tests with `python test/test_jit.py TestNnapiBackend` Reviewers: Subscribers: myuan Tasks: Tags: Differential Revision: [D29799895](https://our.internmc.facebook.com/intern/diff/D29799895) [ghstack-poisoned]
iseeyuan
approved these changes
Jul 20, 2021
|
@Amyh11325 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…reprocess: Basic OSS Test"" ### Summary: **CMakeLists.txt** Android NNAPI delegate library was moved from test/cpp/jit/CMakeLists.txt to torch/CMakeLists.txt. This resolves the issue the original PR had, where the NNAPI delegate library was added to builds without Python (when it depends on Python). **Original PR**: #61594 There's an error where the library cannot be built on MacOS. This problem existed in the original PR as well, but now an issue has been created: #61930 **test_backend_nnapi.py** Also changed the skip unit test headers so that it's a little cleaner. Now the unit tests are skipped if the Nnapi delegate library file is not found. Previously, the skip was based on the platform (only allowing Linux). ### Test Plan: Ran NNAPI delegate unit tests with `python test/test_jit.py TestNnapiBackend` Reviewers: Subscribers: myuan Tasks: Tags: Differential Revision: [D29799895](https://our.internmc.facebook.com/intern/diff/D29799895) [ghstack-poisoned]
|
@Amyh11325 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been merged in a03466c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
CMakeLists.txt
Android NNAPI delegate library was moved from test/cpp/jit/CMakeLists.txt to torch/CMakeLists.txt. This resolves the issue the original PR had, where the NNAPI delegate library was added to builds without Python (when it depends on Python).
Original PR: #61594
There's an error where the library cannot be built on MacOS. This problem existed in the original PR as well, but now an issue has been created: #61930
test_backend_nnapi.py
Also changed the skip unit test headers so that it's a little cleaner. Now the unit tests are skipped if the Nnapi delegate library file is not found. Previously, the skip was based on the platform (only allowing Linux).
Test Plan:
Ran NNAPI delegate unit tests with
python test/test_jit.py TestNnapiBackendReviewers:
Subscribers:
myuan
Tasks:
Tags:
Differential Revision: D29799895