-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DDP][ez] Remove misleading comment #62230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't iterate over model replicas anymore. Differential Revision: [D29918760](https://our.internmc.facebook.com/intern/diff/D29918760/) [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 4da89eb (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced Jul 26, 2021
wayi1
approved these changes
Jul 27, 2021
We don't iterate over model replicas anymore. Differential Revision: [D29918760](https://our.internmc.facebook.com/intern/diff/D29918760/) [ghstack-poisoned]
We don't iterate over model replicas anymore. Differential Revision: [D29918760](https://our.internmc.facebook.com/intern/diff/D29918760/) [ghstack-poisoned]
This pull request has been merged in c76daa6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We don't iterate over model replicas anymore.
Differential Revision: D29918760