[PyTorch Edge] Simplify Exception Handling (Take-2) (module.cpp) #62634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the same set of changes as in D27688352 to `module.cpp` as instructed by @xcheng16. Basically, this simplifies exception handling and allows propagation of the original message undisturbed to the caller so that we can figure out the lineage of the exception in crash tasks such as t96812652 Differential Revision: [D30038867](https://our.internmc.facebook.com/intern/diff/D30038867/) [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit dec955d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
dhruvbird
added a commit
that referenced
this pull request
Aug 3, 2021
Apply the same set of changes as in D27688352 to `module.cpp` as instructed by @xcheng16. Basically, this simplifies exception handling and allows propagation of the original message undisturbed to the caller so that we can figure out the lineage of the exception in crash tasks such as t96812652 Differential Revision: [D30038867](https://our.internmc.facebook.com/intern/diff/D30038867/) ghstack-source-id: 134877012 Pull Request resolved: #62634
|
This pull request has been merged in 019048b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Apply the same set of changes as in D27688352 to
module.cppas instructed by @xcheng16.Basically, this simplifies exception handling and allows propagation of the original message undisturbed to the caller so that we can figure out the lineage of the exception in crash tasks such as t96812652
Differential Revision: D30038867