Add getPyInterpreter() API #62659
Closed
Add getPyInterpreter() API #62659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that it is occasionally useful to be able to access the PyInterpreter object from other Python bindings (see next diff in the stack). Make it publicly available. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 40aafaa (more details on the Dr. CI page):
1 failure not recognized by patterns:
🚧 9 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
bdhirsh
reviewed
Aug 3, 2021
| return THPVariable_Unpack(reinterpret_cast<THPVariable*>(obj)); | ||
| } | ||
|
|
||
| THP_API c10::impl::PyInterpreter* getPyInterpreter(); |
There was a problem hiding this comment.
How is THP_API different from TORCH_API? (and why do we want it here?)
There was a problem hiding this comment.
it's the one for stuff in torch_python, which this file is in
albanD
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It turns out that it is occasionally useful to be able to access the
PyInterpreter object from other Python bindings (see next diff in the
stack). Make it publicly available.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D30074926