[JIT] Add aten::slice optimization #63049
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 56f5be7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D30231044 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D30231044 |
mikeiovine
force-pushed
the
export-D30231044
branch
from
1059893 to
d028415
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30231044 |
mikeiovine
force-pushed
the
export-D30231044
branch
from
d028415 to
6b6bb0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #63049 +/- ##
==========================================
- Coverage 66.77% 66.76% -0.01%
==========================================
Files 695 695
Lines 90761 90761
==========================================
- Hits 60602 60598 -4
- Misses 30159 30163 +4 |
Summary: Pull Request resolved: pytorch#63049 Given a graph produced from a function like this: ``` def foo(): li = [1, 2, 3, 4, 5, 6] return li[0:2] ``` This pass produces a graph like this: ``` def foo(): li = [1, 2] return li ``` These changes are mostly adapted from pytorch#62297 Test Plan: `buck test //caffe2/test:jit -- TestPeephole` Reviewed By: eellison Differential Revision: D30231044 fbshipit-source-id: 0de4f67f183a725fd5d4fda239299fb3449149db
|
This pull request was exported from Phabricator. Differential Revision: D30231044 |
mikeiovine
force-pushed
the
export-D30231044
branch
from
6b6bb0a to
56f5be7
Compare
|
This pull request has been merged in babd449. |
|
This pull request has been reverted by 65050ec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Given a graph produced from a function like this:
This pass produces a graph like this:
These changes are mostly adapted from #62297
Test Plan:
buck test //caffe2/jit:test -- TestPeepholeDifferential Revision: D30231044