Fix batch_isend_irecv tests for err case

[zasdfgbnm]

• batch_isend_irecv returns a list of requests instead of a single request
• remove some unused variables

[facebook-github-bot]

🔗 Helpful links

• 🧪  See artifacts and rendered test results at hud.pytorch.org/pr/63112
• 📄  Preview docs built from this PR
• 📄  Preview C++ docs built from this PR
• 🔧  Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 87ee5ac (more details on the Dr. CI page):

---

• 1/1 failures introduced in this PR

---

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-cuda11.3-py3.6-gcc7 / test (distributed, 1, 1, linux.8xlarge.nvidia.gpu) (1/1)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-09-15T06:59:37.0188258Z AssertionError: Fa... dtypes. Got dtypes torch.float32 and torch.int64.

2021-09-15T06:59:37.0177917Z   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 111, in wrapper
2021-09-15T06:59:37.0178771Z     return func(*args, **kwargs)
2021-09-15T06:59:37.0179748Z   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 2848, in wrapper
2021-09-15T06:59:37.0180547Z     return func(*args, **kwargs)
2021-09-15T06:59:37.0181737Z   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/distributed/distributed_test.py", line 4644, in test_post_localSGD_optimizer_parity
2021-09-15T06:59:37.0182802Z     self.assertEqual(p1.data, p2.data)
2021-09-15T06:59:37.0183895Z   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1875, in assertEqual
2021-09-15T06:59:37.0185091Z     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
2021-09-15T06:59:37.0186008Z   File "/opt/conda/lib/python3.6/unittest/case.py", line 682, in assertTrue
2021-09-15T06:59:37.0186780Z     raise self.failureException(msg)
2021-09-15T06:59:37.0188258Z AssertionError: False is not true : Tensors failed to compare as equal!Attempted to compare equality of tensors with different dtypes. Got dtypes torch.float32 and torch.int64.
2021-09-15T06:59:37.0189193Z 
2021-09-15T06:59:37.0189426Z 
2021-09-15T06:59:37.0189731Z 		
2021-09-15T06:59:37.0190295Z ✅ 534 Passed
2021-09-15T06:59:37.0190810Z 💨 197 Skipped
2021-09-15T06:59:37.0191288Z 🚨 1 Failed
2021-09-15T06:59:37.0396276Z ##[group]Run # Remove any previous test reports if they exist
2021-09-15T06:59:37.0397180Z �[36;1m# Remove any previous test reports if they exist�[0m
2021-09-15T06:59:37.0397806Z �[36;1mrm -f test-reports-*.zip�[0m
2021-09-15T06:59:37.0398476Z �[36;1mzip -r "test-reports-${FILE_SUFFIX}.zip" test -i '*.xml'�[0m

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[pritamdamania87]

I'm assuming this unit test passed since the code after dist.batch_isend_irecv was never executed and batch_isend_irecv just threw an exception. If so, should we just call dist.batch_isend_irecv here and ignore the return value?

[zasdfgbnm]

Yes, I agree, will update soon.

[facebook-github-bot]

@pritamdamania87 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[zasdfgbnm]

@pritamdamania87 I have resolved your review comment.

[codecov]

Codecov Report

Merging #63112 (87ee5ac) into master (d6d286f) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #63112      +/-   ##
==========================================
- Coverage   66.47%   66.39%   -0.08%     
==========================================
  Files         725      725              
  Lines       93457    93448       -9     
==========================================
- Hits        62122    62046      -76     
- Misses      31335    31402      +67     

[facebook-github-bot]

@pritamdamania87 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.