Skip to content

Conversation

ngimel
Copy link
Collaborator

@ngimel ngimel commented Aug 18, 2021

Fixes #63427

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 18, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit a5a704f (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ngimel ngimel requested a review from zasdfgbnm August 18, 2021 01:29
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #63451 (a5a704f) into master (dcf90b7) will increase coverage by 14.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #63451       +/-   ##
===========================================
+ Coverage   59.86%   74.46%   +14.59%     
===========================================
  Files        2068     2117       +49     
  Lines      210331   212216     +1885     
===========================================
+ Hits       125921   158028    +32107     
+ Misses      84410    54188    -30222     

@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in ce6fe50.

@ngimel ngimel deleted the ngimel/revert_emb branch December 26, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird behavior of cuda::cub::sort_pairs

3 participants