[Static Runtime] Implement prim::VarStack out variant #63579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8c49809 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D30410525 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D30410525 |
mikeiovine
force-pushed
the
export-D30410525
branch
from
fa04503 to
89e5bd3
Compare
Codecov Report
@@ Coverage Diff @@
## master #63579 +/- ##
==========================================
+ Coverage 75.44% 75.53% +0.08%
==========================================
Files 2122 2123 +1
Lines 212875 212895 +20
==========================================
+ Hits 160612 160817 +205
+ Misses 52263 52078 -185 |
added 3 commits
August 23, 2021 06:29
Summary: Pull Request resolved: pytorch#63577 Since other variadic ops will have an almost identical implementation, we can generalize the `UseVariadicCat` implementation and put it in a common folder. Also moved some test utilities that other variadic op tests will likely need. Test Plan: `buck test caffe2/test/cpp/jit:jit -- ConcatOptTest` Differential Revision: D30409937 fbshipit-source-id: 3c8402541c0265ad46455971c32ea7393b3f0171
Summary: Pull Request resolved: pytorch#63578 Added a new op `prim::VarStack` and a pass that transforms instances of `aten::stack(list, dim)` into `prim::VarStack(list[0], ..., list[n], dim)`. Also provided a JIT interpreter implementation. Most of the implementation/tests are the same as `prim::VarConcat`. Test Plan: `buck test caffe2/test/cpp/jit:jit -- TestStackOpt` Differential Revision: D30426232 fbshipit-source-id: 5c5e3bfb0695e1674e2067e16c06feb6d6517536
Summary: Pull Request resolved: pytorch#63579 Provide a static runtime out variant implementation for the new op introduced in D30426232. Test Plan: `buck test //caffe2/benchmarks/static_runtime:static_runtime_cpptest -- IndividualOps_VarStack` Reviewed By: navahgar Differential Revision: D30410525 fbshipit-source-id: 990de152ae1ac67f264642f89c1fa04fa868b8e4
|
This pull request was exported from Phabricator. Differential Revision: D30410525 |
mikeiovine
force-pushed
the
export-D30410525
branch
from
89e5bd3 to
8c49809
Compare
|
This pull request has been merged in 7774a4e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Provide a static runtime out variant implementation for the new op introduced in D30426232.
Test Plan:
buck test //caffe2/benchmarks/static_runtime:static_runtime_cpptest -- IndividualOps_VarStackDifferential Revision: D30410525
cc @gmagogsfm