Skip to content

[TensorExpr] Nuke KernelArena and KernelScope. #63587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[TensorExpr] Nuke KernelArena and KernelScope. #63587

wants to merge 10 commits into from

Conversation

ZolotukhinM
Copy link

@ZolotukhinM ZolotukhinM commented Aug 19, 2021 •
edited by pytorch-probot bot
Loading

This was referenced Aug 19, 2021
Closed
Closed
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Aug 19, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 19, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit c4d6ab5 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ZolotukhinM pushed a commit that referenced this pull request Aug 19, 2021
[TensorExpr] Nuke KernelArena and KernelScope.
d714e5f 
ghstack-source-id: 79b4e4f
Pull Request resolved: #63587
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[TensorExpr] Nuke KernelArena and KernelScope."
c5b83c3 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[TensorExpr] Nuke KernelArena and KernelScope."
1f35bb7 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[TensorExpr] Nuke KernelArena and KernelScope."
c761ca3 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

rebase on "[TensorExpr] Nuke KernelArena and KernelScope."
ece6404 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
ZolotukhinM pushed a commit that referenced this pull request Aug 19, 2021
[TensorExpr] Nuke KernelArena and KernelScope.
941ae39 
Now that there is no classes using KernelArena for memory management we
can remove it.

ghstack-source-id: 70377b1
Pull Request resolved: #63587
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[TensorExpr] Nuke KernelArena and KernelScope."
3e1d4a5 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

rebase on "[TensorExpr] Nuke KernelArena and KernelScope."
6c7b4b3 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
ZolotukhinM pushed a commit that referenced this pull request Aug 22, 2021
[TensorExpr] Nuke KernelArena and KernelScope.
382e605 
Now that there is no classes using KernelArena for memory management we
can remove it.

ghstack-source-id: 90eed75
Pull Request resolved: #63587
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Update on "[TensorExpr] Nuke KernelArena and KernelScope."
6417a67 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
ZolotukhinM pushed a commit that referenced this pull request Aug 23, 2021
[TensorExpr] Nuke KernelArena and KernelScope.
5519e37 
Now that there is no classes using KernelArena for memory management we
can remove it.

ghstack-source-id: 884c9d3
Pull Request resolved: #63587
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ZolotukhinM ZolotukhinM mentioned this pull request Aug 23, 2021
Closed
Update on "[TensorExpr] Nuke KernelArena and KernelScope."
c4d6ab5 
Now that there is no classes using KernelArena for memory management we
can remove it.

Differential Revision: [D30429115](https://our.internmc.facebook.com/intern/diff/D30429115)

[ghstack-poisoned]
ZolotukhinM pushed a commit that referenced this pull request Aug 23, 2021
[TensorExpr] Nuke KernelArena and KernelScope.
dab4726 
Now that there is no classes using KernelArena for memory management we
can remove it.

ghstack-source-id: 884c9d3
Pull Request resolved: #63587
@ZolotukhinM
Copy link
Author

@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar
navahgar approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@ZolotukhinM merged this pull request in f0d2742.

@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/464/head branch August 27, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertmaher bertmaher Awaiting requested review from bertmaher

@huiguoo huiguoo Awaiting requested review from huiguoo

@Chillee Chillee Awaiting requested review from Chillee

1 more reviewer

@navahgar navahgar navahgar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZolotukhinM @facebook-github-bot @navahgar