Add a comment on the potential implicit type up-casting #63905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as title Differential Revision: [D30527929](https://our.internmc.facebook.com/intern/diff/D30527929/) [ghstack-poisoned]
wayi1
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7233407 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
wayi1
pushed a commit
that referenced
this pull request
Aug 24, 2021
as title Differential Revision: [D30527929](https://our.internmc.facebook.com/intern/diff/D30527929/) ghstack-source-id: 136590703 Pull Request resolved: #63905
wayi1
changed the title
as title Differential Revision: [D30527929](https://our.internmc.facebook.com/intern/diff/D30527929/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Aug 25, 2021
Pull Request resolved: #63905 as title ghstack-source-id: 136590703 Differential Revision: [D30527929](https://our.internmc.facebook.com/intern/diff/D30527929/)
mrshenli
approved these changes
Aug 25, 2021
|
This pull request has been merged in 7edeead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
as title
Differential Revision: D30527929
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @agolynski @SciPioneer @H-Huang @mrzzd @cbalioglu @gcramer23