Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Aug 25, 2021

Stack from ghstack:

This slightly improves performance of model loading; leaving it to reviewers to decide whether it's worth the increased maintenance cost (mentioned in the header).

Differential Revision: D30555327

This slightly improves performance of model loading; leaving it to reviewers to decide whether it's worth the increased maintenance cost (mentioned in the header).

Differential Revision: [D30555327](https://our.internmc.facebook.com/intern/diff/D30555327/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 25, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 2a7bdd0 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Aug 25 21:12:47 CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
Aug 25 21:12:46 invalid command 'bad_argument'
Aug 25 21:12:46 + retcode=1
Aug 25 21:12:46 + set -e
Aug 25 21:12:46 + return 1
Aug 25 21:12:46 + [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *libtorch* ]]
Aug 25 21:12:46 + [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *ppc64le* ]]
Aug 25 21:12:46 + [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *clang* ]]
Aug 25 21:12:46 + WERROR=1
Aug 25 21:12:46 + python setup.py bdist_wheel
Aug 25 21:12:47 Building wheel torch-1.10.0a0+gitbe92d2b
Aug 25 21:12:47 CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
Aug 25 21:12:47   CMake 3.10 or higher is required.  You are running version 3.5.1
Aug 25 21:12:47 
Aug 25 21:12:47 
Aug 25 21:12:47 -- Configuring incomplete, errors occurred!
Aug 25 21:12:47 -- Building version 1.10.0a0+gitbe92d2b
Aug 25 21:12:47 cmake -DBUILD_ENVIRONMENT=pytorch-linux-xenial-py3.6-gcc5.4-build -DBUILD_PYTHON=True -DBUILD_STATIC_RUNTIME_BENCHMARK=ON -DBUILD_TEST=True -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/var/lib/jenkins/workspace/torch -DCMAKE_PREFIX_PATH=/opt/conda/lib/python3.6/site-packages;/opt/conda -DNUMPY_INCLUDE_DIR=/opt/conda/lib/python3.6/site-packages/numpy/core/include -DOPENSSL_ROOT_DIR=/opt/openssl -DPYTHON_EXECUTABLE=/opt/conda/bin/python -DPYTHON_INCLUDE_DIR=/opt/conda/include/python3.6m -DPYTHON_LIBRARY=/opt/conda/lib/libpython3.6m.so.1.0 -DTORCH_BUILD_VERSION=1.10.0a0+gitbe92d2b -DUSE_GLOO_WITH_OPENSSL=ON -DUSE_LLVM=/opt/llvm -DUSE_NUMPY=True -DWERROR=1 /var/lib/jenkins/workspace
Aug 25 21:12:47 + cleanup
Aug 25 21:12:47 + retcode=1
Aug 25 21:12:47 + set +x
Aug 25 21:12:47 =================== sccache compilation log ===================

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Lint / clang-format Run clang-format 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Aug 25, 2021
swolchok added a commit that referenced this pull request Aug 25, 2021
This slightly improves performance of model loading; leaving it to reviewers to decide whether it's worth the increased maintenance cost (mentioned in the header).

Differential Revision: [D30555327](https://our.internmc.facebook.com/intern/diff/D30555327/)

ghstack-source-id: 136682299
Pull Request resolved: #63984
@swolchok swolchok closed this Sep 23, 2021
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/273/head branch October 24, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants