.circleci: Remove migrated jobs, move docs builds #64222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes both backwards_compat as well as docs_test from the general gcc5.4 config and moves the docs build from being run on every PR to only being run on master. We can remove docs builds when we migrate the docs push job (including all secrets associated with that) Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e646bcc (more details on the Dr. CI page):
❄️ 2 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
seemethere
added a commit
that referenced
this pull request
Aug 30, 2021
Removes both backwards_compat as well as docs_test from the general gcc5.4 config and moves the docs build from being run on every PR to only being run on master. We can remove docs builds when we migrate the docs push job (including all secrets associated with that) Signed-off-by: Eli Uriegas <eliuriegas@fb.com> ghstack-source-id: a9498b3 Pull Request resolved: #64222
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
8 tasks
driazati
reviewed
Aug 31, 2021
| ) | ||
| ) | ||
|
|
||
| configs.append( |
There was a problem hiding this comment.
Where does this run now? I don't see it in the HUD anywhere (from test.sh it looks like the job name needs to have doc_test?)
There was a problem hiding this comment.
should now be docs_test, added to GHA in #64201
malfet
approved these changes
Aug 31, 2021
|
@seemethere merged this pull request in 555171a. |
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Sep 8, 2021
That were accidentally disabled by pytorch#64222
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Removes both backwards_compat as well as docs_test from the general
gcc5.4 config and moves the docs build from being run on every PR to
only being run on master.
We can remove docs builds when we migrate the docs push job (including
all secrets associated with that)
Signed-off-by: Eli Uriegas eliuriegas@fb.com
cc @ezyang @seemethere @malfet @walterddr @lg20987 @pytorch/pytorch-dev-infra
Differential Revision: D30650953