Skip to content

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Sep 1, 2021

Stack from ghstack:

custom_opsets arg from torch.onnx.export() is no needed to be removed.

Add some supplementary description and tests for easier understanding.

Co-authored-by: hwangdeyu dejack953@outlook.com

Differential Revision: D30905269

…m from torch.onnx.export() function. (#62085)

custom_opsets arg from torch.onnx.export() is no needed to be removed.

Add some supplementary description and tests for easier understanding.

Co-authored-by: hwangdeyu <dejack953@outlook.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 1, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 5c1ee79 (more details on the Dr. CI page):


  • 1/2 failures introduced in this PR
  • 1/2 broken upstream at merge base 15f06d7 on Sep 01 from 10:31am to 10:53am

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-cuda11.3-py3.6-gcc7 / test (default, 2, 2, linux.8xlarge.nvidia.gpu) (1/1)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2021-09-22T21:02:17.4814508Z Intel MKL ERROR: Parameter 5 was incorrect on entry to DLASCL.
2021-09-22T21:02:17.1690653Z Intel MKL ERROR: Parameter 5 was incorrect on entry to DLASCL.
2021-09-22T21:02:17.1726745Z ok (0.158s)
2021-09-22T21:02:17.2900220Z   test_cond_cuda_float32 (__main__.TestLinalgCUDA) ... 
2021-09-22T21:02:17.2901011Z Intel MKL ERROR: Parameter 4 was incorrect on entry to DLASCL.
2021-09-22T21:02:17.2901466Z 
2021-09-22T21:02:17.2901993Z Intel MKL ERROR: Parameter 5 was incorrect on entry to DLASCL.
2021-09-22T21:02:17.2936017Z ok (0.121s)
2021-09-22T21:02:17.4812705Z   test_cond_cuda_float64 (__main__.TestLinalgCUDA) ... 
2021-09-22T21:02:17.4813511Z Intel MKL ERROR: Parameter 4 was incorrect on entry to DLASCL.
2021-09-22T21:02:17.4813975Z 
2021-09-22T21:02:17.4814508Z Intel MKL ERROR: Parameter 5 was incorrect on entry to DLASCL.
2021-09-22T21:02:17.4847942Z ok (0.191s)
2021-09-22T21:02:17.5506050Z   test_cond_errors_and_warnings_cuda_complex128 (__main__.TestLinalgCUDA) ... ok (0.066s)
2021-09-22T21:02:17.6151571Z   test_cond_errors_and_warnings_cuda_complex64 (__main__.TestLinalgCUDA) ... ok (0.064s)
2021-09-22T21:02:17.6792361Z   test_cond_errors_and_warnings_cuda_float32 (__main__.TestLinalgCUDA) ... ok (0.064s)
2021-09-22T21:02:17.7440424Z   test_cond_errors_and_warnings_cuda_float64 (__main__.TestLinalgCUDA) ... ok (0.065s)
2021-09-22T21:02:17.7451188Z   test_cross_cuda_float32 (__main__.TestLinalgCUDA) ... skip (0.001s)
2021-09-22T21:02:17.7761774Z   test_cross_errors_cuda (__main__.TestLinalgCUDA) ... ok (0.031s)
2021-09-22T21:02:17.7772747Z   test_cross_with_and_without_dim_cuda_float32 (__main__.TestLinalgCUDA) ... skip (0.001s)
2021-09-22T21:02:17.8286555Z   test_det_cuda_complex128 (__main__.TestLinalgCUDA) ... ok (0.051s)
2021-09-22T21:02:17.8589626Z   test_det_cuda_float64 (__main__.TestLinalgCUDA) ... ok (0.030s)

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…opsets param from torch.onnx.export() function. (#62085)"

custom_opsets arg from torch.onnx.export() is no needed to be removed.

Add some supplementary description and tests for easier understanding.

Co-authored-by: hwangdeyu <dejack953@outlook.com>

[ghstack-poisoned]
…opsets param from torch.onnx.export() function. (#62085)"

custom_opsets arg from torch.onnx.export() is no needed to be removed.

Add some supplementary description and tests for easier understanding.

Co-authored-by: hwangdeyu <dejack953@outlook.com>

[ghstack-poisoned]
…opsets param from torch.onnx.export() function. (#62085)"

custom_opsets arg from torch.onnx.export() is no needed to be removed.

Add some supplementary description and tests for easier understanding.

Co-authored-by: hwangdeyu <dejack953@outlook.com>

[ghstack-poisoned]
@msaroufim
Copy link
Member

@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…opsets param from torch.onnx.export() function. (#62085)"

custom_opsets arg from torch.onnx.export() is no needed to be removed.

Add some supplementary description and tests for easier understanding.

Co-authored-by: hwangdeyu <dejack953@outlook.com>

Differential Revision: [D30905269](https://our.internmc.facebook.com/intern/diff/D30905269)

[ghstack-poisoned]
@malfet
Copy link
Contributor

malfet commented Sep 22, 2021

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…opsets param from torch.onnx.export() function. (#62085)"

custom_opsets arg from torch.onnx.export() is no needed to be removed.

Add some supplementary description and tests for easier understanding.

Co-authored-by: hwangdeyu <dejack953@outlook.com>

Differential Revision: [D30905269](https://our.internmc.facebook.com/intern/diff/D30905269)

[ghstack-poisoned]
@malfet
Copy link
Contributor

malfet commented Sep 22, 2021

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 9965163.

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/114/head branch September 27, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants