[POC] .github: Add event name to concurrency #64402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 4febb45 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #64402 +/- ##
==========================================
+ Coverage 66.68% 66.72% +0.04%
==========================================
Files 708 708
Lines 92215 92271 +56
==========================================
+ Hits 61489 61566 +77
+ Misses 30726 30705 -21 |
zhouzhuojie
reviewed
Sep 2, 2021
There was a problem hiding this comment.
🎉 great idea!
btw, there's a lint error on line length. side note: wondering why lint annotation didn't work here
janeyx99
force-pushed
the
add-event-name-to-concurrency
branch
from
da26f90 to
4febb45
Compare
driazati
approved these changes
Sep 2, 2021
Comment on lines
47
to
50
| concurrency: | ||
| group: !{{ build_environment }}-${{ github.event.pull_request.number || github.sha }} | ||
| group: !{{ build_environment }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name == 'workflow_dispatch' }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
not necessary for this PR but it'd be good to move the concurrency group stuff into a macro
|
@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would ensure that manually/API triggered workflows would not cancel other triggered workflows. For example, the manually triggered periodic 11.1 linux job cancelled the scheduled one here, which we may not want:
.
This would be helpful later as we use more dispatched workflows (e.g., for bisect functionality)