[fx] make const fold code more pythonic #64451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5332a8f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D30718255 |
Codecov Report
@@ Coverage Diff @@
## master #64451 +/- ##
==========================================
- Coverage 66.71% 66.65% -0.06%
==========================================
Files 710 710
Lines 92406 92406
==========================================
- Hits 61645 61593 -52
- Misses 30761 30813 +52 |
Summary: Pull Request resolved: pytorch#64451 No functional change. Test Plan: ``` buck test caffe2/test:fx_const_fold ``` Reviewed By: jfix71, houseroad Differential Revision: D30718255 fbshipit-source-id: 14a76dbc4b886c90bafebec11a104251e1ef823c
|
This pull request was exported from Phabricator. Differential Revision: D30718255 |
yinghai
force-pushed
the
export-D30718255
branch
from
de41e16 to
5332a8f
Compare
|
This pull request has been merged in b121506. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: No functional change.
Test Plan:
Differential Revision: D30718255