-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[fix] fix test_python_dispatch with pytest #64574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] fix test_python_dispatch with pytest #64574
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1dee3ad (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #64574 +/- ##
==========================================
- Coverage 66.65% 66.65% -0.01%
==========================================
Files 714 714
Lines 92546 92546
==========================================
- Hits 61685 61682 -3
- Misses 30861 30864 +3 |
@kshitij12345 thanks for opening the conversation here. Is my understanding correct that the problem is that pytest installs its own log handler, and then our logs here propagate to their log handling which chokes on the full objects? In that case, it seems to me a more straightforward fix would be just to prevent propagation. (We're logging to a specific named logger so disabling propagation for this name only seems fine.) |
ebe66cf
to
1d701d1
Compare
Did not know about this. Should be ready now. Thank you very much @ezyang! |
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Fixes #62501
Another approach for fixing the same issue