Skip to content

[PyTorch] Use std::find in the JIT lexer #64652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[PyTorch] Use std::find in the JIT lexer #64652

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67802ff
[PyTorch] Use std::find in the JIT lexer
swolchok Sep 8, 2021
bad08c3
Update on "[PyTorch] Use std::find in the JIT lexer"
swolchok Sep 8, 2021
fe5e5d3
Update on "[PyTorch] Use std::find in the JIT lexer"
swolchok Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions torch/csrc/jit/frontend/lexer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,16 +337,12 @@ struct TORCH_API SharedParserData {
// rather the
// identifier 'max'
if (cur) {
size_t child_offset = 0;
for (size_t e = cur->child_chars.size(); child_offset < e;
++child_offset) {
if (cur->child_chars[child_offset] == str[pos + i])
break;
}
const auto begin_it = cur->child_chars.begin();
const auto end_it = cur->child_chars.end();
const auto ch_it = std::find(begin_it, end_it, str[pos + i]);

cur = (child_offset == cur->child_chars.size())
? nullptr
: cur->child_tries[child_offset].get();
cur = (ch_it == end_it) ? nullptr
: cur->child_tries[ch_it - begin_it].get();

if (cur && cur->kind != 0) {
matched = true;
Expand Down