Add support for lowering info during serialize_module, and add padding/partial to it #64725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/partial to it Summary: - Any info added to the dict in node.meta["lowering_info"] will be added to the node_rep during serialization. - Use this to add annotations on placeholders that allow partial inputs and require padding. - Check for these annotations and set them in the NNPICompiledFunction as expected Test Plan: Validated working on inline_cvr in stack. Additionally existing fx_glow end to end tests should still pass. Differential Revision: D30824192 fbshipit-source-id: bef28b6338f40e68090e5759ac011cd56a61a994
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8af6313 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D30824192 |
jfix71
added a commit
to jfix71/glow
that referenced
this pull request
Sep 9, 2021
…g/partial to it (#64725) Summary: Pull Request resolved: pytorch/pytorch#64725 - Any info added to the dict in node.meta["lowering_info"] will be added to the node_rep during serialization. - Use this to add annotations on placeholders that allow partial inputs and require padding. - Check for these annotations and set them in the NNPICompiledFunction as expected Differential Revision: D30824192 fbshipit-source-id: a3a3f6c0b350eb06c6481893087a1d2c25179b8c
Codecov Report
@@ Coverage Diff @@
## master #64725 +/- ##
==========================================
- Coverage 66.62% 66.62% -0.01%
==========================================
Files 710 710
Lines 92433 92438 +5
==========================================
+ Hits 61582 61583 +1
- Misses 30851 30855 +4 |
|
This pull request has been merged in a33fff6. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
…g/partial to it (#5810) Summary: Pull Request resolved: pytorch/glow#5810 Pull Request resolved: #64725 - Any info added to the dict in node.meta["lowering_info"] will be added to the node_rep during serialization. - Use this to add annotations on placeholders that allow partial inputs and require padding. - Check for these annotations and set them in the NNPICompiledFunction as expected Test Plan: Validated working on inline_cvr in stack. Additionally existing fx_glow end to end tests should still pass. Reviewed By: 842974287 Differential Revision: D30824192 fbshipit-source-id: def64ef097aa35c337abb494415f7d437c6c7fa9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: Validated working on inline_cvr in stack. Additionally existing fx_glow end to end tests should still pass.
Differential Revision: D30824192