Pass GITHUB_TOKEN to linux CI jobs and avoid skipping torchhub tests #64807
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2db3538 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
According to https://github.com/pytorch/pytorch/pull/64807/checks?check_run_id=3565497882 the torchhub tests are properly passing now (i.e. they're not skipped). |
| CUSTOM_TEST_ARTIFACT_BUILD_DIR: build/custom_test_artifacts | ||
| ALPINE_IMAGE: "308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine" | ||
| PR_LABELS: ${{ toJson(github.event.pull_request.labels.*.name) }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I only changed the linux template, I'm not sure the windows tests are running the torchhub tests. @seemethere would you know how I could confirm that?
There was a problem hiding this comment.
We'll also need to add -e GITHUB_TOKEN to the docker runs as well so that it gets propagated to the container as well
There was a problem hiding this comment.
Actually nvm, we already do this since we create an env file that gets auto-included in our docker runs:
pytorch/.github/templates/common.yml.j2
Lines 84 to 86 in 67bd2a3
NicolasHug
requested review from
driazati,
janeyx99,
seemethere and
zhouzhuojie
as code owners
NicolasHug
changed the title
Codecov Report
@@ Coverage Diff @@
## master #64807 +/- ##
==========================================
+ Coverage 66.38% 66.46% +0.08%
==========================================
Files 727 727
Lines 93573 93573
==========================================
+ Hits 62117 62193 +76
+ Misses 31456 31380 -76 |
…_gh_token_to_ci_jobs
| CUSTOM_TEST_ARTIFACT_BUILD_DIR: build/custom_test_artifacts | ||
| ALPINE_IMAGE: "308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine" | ||
| PR_LABELS: ${{ toJson(github.event.pull_request.labels.*.name) }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Actually nvm, we already do this since we create an env file that gets auto-included in our docker runs:
pytorch/.github/templates/common.yml.j2
Lines 84 to 86 in 67bd2a3
|
@NicolasHug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…_gh_token_to_ci_jobs
|
@NicolasHug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@NicolasHug merged this pull request in 9157a28. |
3 participants
Fixes #64760
This should hopefully put the torchhub tests back.
This also avoids skipping the torchhub tests: currently the tests are skipped if they fail, which pretty much defeats the purpose of having a test in the first place since we're never notified when they do fail.
cc @ezyang @seemethere @malfet @lg20987 @pytorch/pytorch-dev-infra @nairbv @NicolasHug