[TensorExpr] Move 2 graph passes from kernel.cpp to graph_opt.cpp #64828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make `removeUnusedSelfArgument` more consistent with other passes by mutating the graph in-place rather than returning a copy. [ghstack-poisoned]
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit f8ce90e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ZolotukhinM
requested review from
Chillee,
bertmaher,
huiguoo and
navahgar
and removed request for
bertmaher
Codecov Report
@@ Coverage Diff @@
## gh/ZolotukhinM/458/base #64828 +/- ##
========================================================
Coverage 66.65% 66.65%
========================================================
Files 710 710
Lines 92402 92402
========================================================
+ Hits 61586 61587 +1
+ Misses 30816 30815 -1 |
|
@ZolotukhinM merged this pull request in 82ac3f1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Also, make
removeUnusedSelfArgumentmore consistent with other passesby mutating the graph in-place rather than returning a copy.
Differential Revision: D30870776