Add dropout shape inference as no-op in acc_tracer #65113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c68d713 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
This pull request was exported from Phabricator. Differential Revision: D30880679 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D30880679 |
Codecov Report
@@ Coverage Diff @@
## master #65113 +/- ##
=======================================
Coverage 66.37% 66.37%
=======================================
Files 727 725 -2
Lines 93571 93575 +4
=======================================
+ Hits 62109 62112 +3
- Misses 31462 31463 +1 |
Summary: Pull Request resolved: #65113 Register dropout as no-op in acc_tracer & Add shape inference for no-op Test Plan: buck test glow/fb/fx/acc_tracer:test_acc_shape_inference --- test_unary_15_dropout_no_op buck test glow/fb/fx/oss_acc_tracer:test_acc_tracer -- test_dropout Reviewed By: jfix71 Differential Revision: D30880679 fbshipit-source-id: d5123ce69b6060b64c4aeda7bf50e89e718a18a4
|
This pull request was exported from Phabricator. Differential Revision: D30880679 |
|
This pull request has been merged in c886406. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Register dropout as no-op in acc_tracer & Add shape inference for no-op
Test Plan:
buck test glow/fb/fx/acc_tracer:test_acc_shape_inference --- test_unary_15_dropout_no_op
buck test glow/fb/fx/oss_acc_tracer:test_acc_tracer -- test_dropout
Reviewed By: jfix71
Differential Revision: D30880679