[PyTorch] Extract parseOperator() into a standalone source file #65179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a0c7092 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D31006555 |
larryliu0820
force-pushed
the
export-D31006555
branch
from
f8c35cf to
55678b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31006555 |
larryliu0820
force-pushed
the
export-D31006555
branch
from
55678b8 to
c370c3b
Compare
iseeyuan
approved these changes
Sep 16, 2021
|
This pull request was exported from Phabricator. Differential Revision: D31006555 |
larryliu0820
force-pushed
the
export-D31006555
branch
from
c370c3b to
1a3a6d4
Compare
larryliu0820
force-pushed
the
export-D31006555
branch
from
1a3a6d4 to
cf2d24c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31006555 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D31006555 |
larryliu0820
force-pushed
the
export-D31006555
branch
from
cf2d24c to
08e6d29
Compare
…rch#65179) Summary: Pull Request resolved: pytorch#65179 This is following up this PR: pytorch#61862. The purpose is to modularize operator parsing so that it can be used as needed without pulling the whole `import.cpp` into build. Test Plan: Added a unit test in `test_lite_predictor.cpp` called `ParseOperators`, similar to `ParseBytecode`. Reviewed By: iseeyuan Differential Revision: D31006555 fbshipit-source-id: 6a6980418ea9f75a7f107e8eea5812526e44ca43
|
This pull request was exported from Phabricator. Differential Revision: D31006555 |
larryliu0820
force-pushed
the
export-D31006555
branch
from
08e6d29 to
a0c7092
Compare
Codecov Report
@@ Coverage Diff @@
## master #65179 +/- ##
==========================================
- Coverage 66.35% 66.27% -0.08%
==========================================
Files 734 734
Lines 93784 93784
==========================================
- Hits 62227 62158 -69
- Misses 31557 31626 +69 |
|
This pull request has been merged in eaf85fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is following up this PR: #61862. The purpose is to modularize operator parsing so that it can be used as needed without pulling the whole
import.cppinto build.Test Plan: Added a unit test in
test_lite_predictor.cppcalledParseOperators, similar toParseBytecode.Differential Revision: D31006555