[ONNX] Do not use numpy in ONNX opsets
#65188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `numpy` is optional dependency, we should avoid using in PyTorch core Replace `torch.tensor([numpy.arange(a, b, c)])` with `torch.arange(a, b, c).unsqueeze(0)` Replace `tuple(numpy.add(a, b))` with `tuple( x + y for (x, y) in zip(a, b)`
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 974b240 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mruberry
approved these changes
Sep 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #65188 +/- ##
==========================================
- Coverage 66.37% 66.34% -0.03%
==========================================
Files 732 732
Lines 93630 93684 +54
==========================================
+ Hits 62144 62156 +12
- Misses 31486 31528 +42 |
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
torch.tensor([numpy.arange(a, b, c)])withtorch.arange(a, b, c).unsqueeze(0)Replace
tuple(numpy.add(a, b))withtuple( x + y for (x, y) in zip(a, b)As
numpyis an optional dependency, it shouldn't be used in PyTorch core by default