Skip to content

Delete code coverage jobs from CI #65362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Delete code coverage jobs from CI #65362

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 20, 2021 •
edited by pytorch-probot bot
Loading

As it does not seem useful to the lots of peope, see https://fb.workplace.com/groups/1144215345733672/posts/2062909540530910

cc @ezyang @seemethere @malfet @pytorch/pytorch-dev-infra

@pytorch-probot
Copy link

pytorch-probot bot commented Sep 20, 2021 •
edited
Loading

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/malfet/pytorch/blob/72a6e5254cc66d4c50a83cc7ffc47a6821cc67a8/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
win-vs2019-cuda10.2-py3 ciflow/all, ciflow/cuda, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 20, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 72a6e52 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet added the module: ci Related to continuous integration label Sep 20, 2021
suo
suo approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@suo suo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

albanD
albanD approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci simplification! 🎉

janeyx99
janeyx99 reviewed Sep 20, 2021
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but are we doing this with the intent of never bringing it back?

@malfet
Copy link
Contributor Author

malfet commented Sep 20, 2021 •
edited
Loading

@janeyx99 at the same time, keeping dead code in the repo is not much better in the long run, and if one chooses to they can always revert this PR to restore functionality.

@malfet malfet force-pushed the malfet/kill-codecov-jobs branch from 6a9a974 to 78c8201 Compare September 20, 2021 19:50
@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet force-pushed the malfet/kill-codecov-jobs branch from 78c8201 to 372332d Compare September 20, 2021 20:41
@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet force-pushed the malfet/kill-codecov-jobs branch from 372332d to 062af2c Compare September 21, 2021 17:20
@malfet
Copy link
Contributor Author

malfet commented Sep 21, 2021 •
edited
Loading

Re-basing and waiting for onnx_ort_test1 tests

@malfet malfet force-pushed the malfet/kill-codecov-jobs branch from 062af2c to 72a6e52 Compare September 22, 2021 12:07
@malfet
Copy link
Contributor Author

malfet commented Sep 22, 2021

onnx_ort test failures were related to an attempt to delete

pytorch/.jenkins/caffe2/test.sh

Line 104 in 127c940

$MAYBE_SUDO pip -q install coverage==4.5.1 -f https://s3.amazonaws.com/ossci-linux/wheels/coverage-4.5.1-cp36-cp36m-macosx_10_12_x86_64.whl

which old caffe2 test still rely upon

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in e331bee.

@malfet malfet deleted the malfet/kill-codecov-jobs branch September 22, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo suo approved these changes

@albanD albanD albanD approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@driazati driazati Awaiting requested review from driazati

@seemethere seemethere Awaiting requested review from seemethere

@zhouzhuojie zhouzhuojie Awaiting requested review from zhouzhuojie

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

Assignees

No one assigned

Labels

cla signed Merged module: ci Related to continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @suo @albanD @janeyx99