Skip to content

Conversation

Nayef211
Copy link
Contributor

Summary

  • Added PandasDataframeWrapper around pandas functions to easily drop-and-replacetorcharrow for Facebook internal use cases
  • Updated relevant datapipe/dataframe usesites to use the new PandasDataframeWrapper instead of calling pandas functions directly

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 21, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 1310abf (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@Nayef211 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Nayef211 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Nayef211 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@VitalyFedyunin
Copy link
Contributor

Pay attention to the TestDataFramesPipes when you will start overriding pandas.

@facebook-github-bot
Copy link
Contributor

@Nayef211 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Nayef211
Copy link
Contributor Author

Pay attention to the TestDataFramesPipes when you will start overriding pandas.

I'm assuming all of those tests will get skipped if pandas isn't available. How do we want to go about running tests for the pandas vs torcharrow implementation of dataframe?

@facebook-github-bot
Copy link
Contributor

@Nayef211 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #65411 (1310abf) into master (0a3cf88) will decrease coverage by 0.05%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##           master   #65411      +/-   ##
==========================================
- Coverage   66.42%   66.37%   -0.06%     
==========================================
  Files         735      740       +5     
  Lines       93899    94321     +422     
==========================================
+ Hits        62372    62603     +231     
- Misses      31527    31718     +191     

@facebook-github-bot
Copy link
Contributor

@Nayef211 merged this pull request in 9d17f21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants