-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Added jit log stream changing function and some refactor #65768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ed78826 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
I checked the occurrences of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
torch/csrc/jit/jit_log.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got some internal testing failures, and I think it's because we're missing "::torch::jit" namespace before "get_jit_logging_output_stream". Do you mind adding it?
Description: - Have only added `stdout` and `stderr` as possible options from python API for now. We can do file path passing later maybe. - Put the class `JitLoggingConfig` in the cpp file as none of its methods were being used outside of this file. Python API: `torch._C._jit_set_logging_stream('stdout|stderr')` C++ API: `::torch::jit::set_jit_logging_output_stream(ostream);` Testing: - Tested python API locally. - Unit test for the C++ API is written
706e41f
to
ed78826
Compare
@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Description:
stdout
andstderr
as possible options from pythonAPI for now. We can do file path passing later maybe.
JitLoggingConfig
in the cpp file as none of its methods were being used outside of this file.Python API:
torch._C._jit_set_logging_stream('stdout|stderr')
C++ API:
::torch::jit::set_jit_logging_output_stream(ostream);
Testing:
Fixes #54182