suppress mypy error #66003
Closed
suppress mypy error #66003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 133e449 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
|
@suo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D31340874](https://our.internmc.facebook.com/intern/diff/D31340874) [ghstack-poisoned]
|
@suo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
seemethere
approved these changes
Oct 1, 2021
Differential Revision: [D31340874](https://our.internmc.facebook.com/intern/diff/D31340874) [ghstack-poisoned]
|
@suo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
vkuzo
added a commit
that referenced
this pull request
Oct 8, 2021
Summary: This was initially broken in #65829 and unbroken in #66003, this PR cleans it up by removing the mypy ignore line. Test Plan: ``` mypy torch/jit/_recursive.py --no-incremental ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D31475100](https://our.internmc.facebook.com/intern/diff/D31475100) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Oct 8, 2021
Summary: This was initially broken in #65829 and unbroken in #66003, this PR cleans it up by removing the mypy ignore line. Test Plan: ``` mypy torch/jit/_recursive.py --no-incremental ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D31475100](https://our.internmc.facebook.com/intern/diff/D31475100) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Summary: Pull Request resolved: #66253 This was initially broken in #65829 and unbroken in #66003, this PR cleans it up by removing the mypy ignore line. Test Plan: ``` mypy torch/jit/_recursive.py --no-incremental ``` Imported from OSS Reviewed By: supriyar Differential Revision: D31475100 fbshipit-source-id: 46ab2ede72c08b926f4f9a6b03b1a1375b884c8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D31340874