test_utils.py: Add another retry to test_download_url_to_file #66159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 4c1ce36 (more details on the Dr. CI page):
2 failures not recognized by patterns:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
janeyx99
commented
Oct 5, 2021
| self.assertEqual(sum_of_state_dict(loaded_state), | ||
| SUM_OF_HUB_EXAMPLE) | ||
|
|
||
| @retry(URLError, tries=3) |
There was a problem hiding this comment.
There's a retry URLError on most of the tests in this file. I just added another layer of retrying to the current test case, but there could be a better subtractive solution
There was a problem hiding this comment.
maybe we could collect all the possible urllib exceptions into a common_utils decorator retry_http or something so we can concentrate it all in one place
seemethere
approved these changes
Oct 5, 2021
driazati
approved these changes
Oct 5, 2021
|
@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
4 tasks
seemethere
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the flakiness concerns mentioned #65439 (comment)